Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error if multiple files are supplied to import command #142

Merged
merged 2 commits into from
Jul 15, 2024
Merged

error if multiple files are supplied to import command #142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d46d368
error if multiple files are supplied to import command
sofuture Jul 15, 2024
9148931
use cobra.ExactArgs for import command
sofuture Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions foxglove/cmd/import.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func newImportCommand(params *baseParams, commandName string) (*cobra.Command, e
importCmd := &cobra.Command{
Use: fmt.Sprintf("%s [FILE]", commandName),
Short: "Import a data file to Foxglove Data Platform",
Args: cobra.ExactArgs(1),
Run: func(cmd *cobra.Command, args []string) {
if edgeRecordingID != "" {
err := importFromEdge(params.baseURL, *params.clientID, params.token, params.userAgent, edgeRecordingID)
Expand All @@ -61,9 +62,6 @@ func newImportCommand(params *baseParams, commandName string) (*cobra.Command, e
return
}

if len(args) == 0 {
dief("Filename not specified")
}
filename := args[0]
err := executeImport(
params.baseURL,
Expand Down
Loading