error if multiple files are supplied to import command #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryfox
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
This works.
You could use an Args validator instead (and drop both length checks); we use it in another spot, so might be good for consistency. On the other hand, the error messaging isn't as specific.
foxglove-cli/foxglove/cmd/extensions.go
Line 25 in bfd0eec
|
I think that's a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Correctly error when multiple files are supplied to the
importcommand.Docs
None
Description
Only one file can be imported at a time per command invocation. Explicitly reject multiple arguments.
Fixes: FG-8204