Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement List Recordings #133

Merged
merged 1 commit into from
Jan 10, 2024
+16 −0
Merged

Fully implement List Recordings #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions foxglove/cmd/recordings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ func newListRecordingsCommand(params *baseParams) *cobra.Command {
var start string
var end string
var importStatus string
var limit int
var offset int
var sortBy string
var sortOrder string
var isJsonFormat bool
recordingsListCmd := &cobra.Command{
Use: "list",
Expand Down Expand Up @@ -48,6 +52,10 @@ func newListRecordingsCommand(params *baseParams) *cobra.Command {
SiteID: primarySiteID,
EdgeSiteID: edgeSiteID,
ImportStatus: importStatus,
Limit: limit,
Offset: offset,
SortBy: sortBy,
SortOrder: sortOrder,
},
client.Recordings,
format,
Expand All @@ -67,6 +75,10 @@ func newListRecordingsCommand(params *baseParams) *cobra.Command {
recordingsListCmd.PersistentFlags().StringVarP(&primarySiteID, "site-id", "", "", "primary site ID")
recordingsListCmd.PersistentFlags().StringVarP(&edgeSiteID, "edge-site-id", "", "", "edge site ID")
recordingsListCmd.PersistentFlags().StringVarP(&importStatus, "import-status", "", "", "import status")
recordingsListCmd.PersistentFlags().IntVarP(&limit, "limit", "", 2000, "max number of recordings to return")
recordingsListCmd.PersistentFlags().IntVarP(&offset, "offset", "", 0, "number of recordings to skip")
recordingsListCmd.PersistentFlags().StringVarP(&sortBy, "sort-by", "", "", "sort recordings by a field")
recordingsListCmd.PersistentFlags().StringVarP(&sortOrder, "sort-order", "", "", "sort order: 'asc' 'desc'")
AddFormatFlag(recordingsListCmd, &format)
AddDeviceAutocompletion(recordingsListCmd, params)
AddJsonFlag(recordingsListCmd, &isJsonFormat)
Expand Down
4 changes: 4 additions & 0 deletions foxglove/console/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ type RecordingsRequest struct {
SiteID string `json:"site.id" form:"site.id,omitempty"`
EdgeSiteID string `json:"edgeSite.id" form:"edgeSite.id,omitempty"`
ImportStatus string `json:"importStatus" form:"importStatus,omitempty"`
Limit int `json:"limit" form:"limit,omitempty"`
Offset int `json:"offset" form:"offset,omitempty"`
SortBy string `json:"sortBy" form:"sortBy,omitempty"`
SortOrder string `json:"sortOrder" form:"sortOrder,omitempty"`
}

type SiteSummary struct {
Expand Down