Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement List Recordings #133

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fully implement List Recordings #133

merged 1 commit into from
Jan 10, 2024

Conversation

christka1
Copy link
Contributor

Public-Facing Changes

More options when using the CLI to list recordings

Description

4 fields where missing from the query params for List Recordings API call, which are all added here

4 fields where missing from the query params, which are all added here
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

@christka1 christka1 marked this pull request as ready for review January 9, 2024 15:32
Copy link
Contributor

@bryfox bryfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@christka1
Copy link
Contributor Author

@bryfox I can't merge since I don't have write access to the repo, would you be so kind as to merge when possible? 🙏

@bryfox bryfox merged commit 52fa2a6 into foxglove:main Jan 10, 2024
3 checks passed
@bryfox
Copy link
Contributor

bryfox commented Jan 10, 2024

We'll cut a new release in the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants