Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude irrelevant directories from asset hashing #9

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Jan 2, 2025

Existing assetExcludesoptions only applies to the rsync step in copying files to the docker container for building. The asset hashing, used to detect source changes, was still being applied to everything in the root directory.
This changes provides defaults (configurable) to exclude cdk, .venv, etc.

@eoinsha eoinsha requested a review from chrismcg January 2, 2025 17:03
Copy link
Contributor

@chrismcg chrismcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a memory of trying something like this back in November and it not working for nested folders. I think it might have been before #5 though.

I assume you've seen improvements with this in your real world use cases?

@eoinsha
Copy link
Contributor Author

eoinsha commented Jan 7, 2025

Yes @chrismcg - tested and seems to work well

@eoinsha eoinsha merged commit 7f4d6bd into main Jan 7, 2025
6 checks passed
@eoinsha eoinsha deleted the fix/optimize-hashing branch January 7, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants