Merge pull request #9 from fourTheorem/fix/optimize-hashing

fix: exclude irrelevant directories from asset hashing
fourTheorem · Jan 7, 2025 · 7f4d6bd · 7f4d6bd
2 parents cdd6184 + 45be196
commit 7f4d6bd
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 11 deletions.
diff --git a/API.md b/API.md
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/bundling.ts b/src/bundling.ts
@@ -14,7 +14,12 @@ import {
 } from 'aws-cdk-lib/aws-lambda';
 import type { BundlingOptions, ICommandHooks } from './types';
 
-export const HASHABLE_DEPENDENCIES_EXCLUDE = ['*.pyc'];
+export const HASHABLE_DEPENDENCIES_EXCLUDE = [
+  '*.pyc',
+  'cdk/**',
+  '.git/**',
+  '.venv/**',
+];
 
 export const DEFAULT_ASSET_EXCLUDES = [
   '.venv/',
@@ -62,17 +67,29 @@ export interface BundlingProps extends BundlingOptions {
    * @default false
    */
   readonly skip?: boolean;
+
+  /**
+   * Glob patterns to exclude from asset hash fingerprinting used for source change
+   * detection
+   *
+   * @default HASHABLE_DEPENDENCIES_EXCLUDE
+   */
+  readonly hashableAssetExclude?: string[];
 }
 
 /**
  * Bundling options for Python Lambda assets
  */
 export class Bundling {
   public static bundle(options: BundlingProps): AssetCode {
+    const {
+      hashableAssetExclude = HASHABLE_DEPENDENCIES_EXCLUDE,
+      ...bundlingOptions
+    } = options;
     return Code.fromAsset(options.rootDir, {
       assetHashType: AssetHashType.SOURCE,
-      exclude: HASHABLE_DEPENDENCIES_EXCLUDE,
-      bundling: new Bundling(options),
+      exclude: hashableAssetExclude,
+      bundling: new Bundling(bundlingOptions),
     });
   }
 

diff --git a/yarn.lock b/yarn.lock