Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore [project/]test.script #775

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Ignore [project/]test.script #775

merged 1 commit into from
Mar 3, 2023

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Mar 3, 2023

In d6c0087 the alias test.script was introduced but wasn't added to the ignored files.
IMHO it's exactly the same like the files [project/]giter8.testand [project/]g8.test

@mkurz mkurz requested review from eed3si9n and xuwei-k as code owners March 3, 2023 21:47
eed3si9n
eed3si9n approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkurz mkurz mentioned this pull request Mar 3, 2023
Merged
2 tasks
@eed3si9n eed3si9n merged commit 684970a into foundweekends:develop Mar 3, 2023
@mkurz mkurz mentioned this pull request Mar 3, 2023
Merged
@mkurz mkurz deleted the ignore_test.script branch March 3, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@xuwei-k xuwei-k Awaiting requested review from xuwei-k xuwei-k is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurz @eed3si9n