Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --force flag to g8Scaffold command #771

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add --force flag to g8Scaffold command #771

merged 1 commit into from
Mar 7, 2023

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Mar 2, 2023 •
edited
Loading

Flag to overwrite existing files.

  • Test
  • Docs (english)

What do you think? IMHO nothing complicated.

@mkurz mkurz requested review from eed3si9n and xuwei-k as code owners March 2, 2023 23:08
mkurz
mkurz commented Mar 2, 2023
View reviewed changes
docs/04/00.md Outdated
@@ -30,6 +30,8 @@ The template plugin will prompt each property that needed to complete the scaffo
className [Application]:
```

The `g8Scaffold` command will not overwrite existing files.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone wants to translate that to Japanese and/or Korean?

@mkurz
Copy link
Contributor Author

mkurz commented Mar 2, 2023

The g8 command already has the --force flag, so I named it "force" too:

giter8/docs/02.md

Lines 60 to 63 in d8ef0a0

To overwrite existing files in the destination folder, you can use:
-f, --force Force overwrite of any existing files in
output directory

@mkurz mkurz mentioned this pull request Mar 3, 2023
Merged
@mkurz mkurz force-pushed the g8ScaffoldForce branch from 5692cbe to 7aa8b7d Compare March 3, 2023 20:47
@mkurz
Copy link
Contributor Author

mkurz commented Mar 3, 2023

@xuwei-k / @eed3si9n Grateful if you could take a look at this PR and #774 (and #775) and hopefully merge it...
Would be awesome if you could cut a new release 🙏 Thanks!

@mkurz
Copy link
Contributor Author

mkurz commented Mar 3, 2023

If you want I can rename to g8ForceScaffold if that would be a better naming.

@mkurz mkurz force-pushed the g8ScaffoldForce branch from 7aa8b7d to 770e515 Compare March 7, 2023 00:02
@mkurz mkurz force-pushed the g8ScaffoldForce branch from 770e515 to b40bc24 Compare March 7, 2023 00:05
@mkurz mkurz requested review from eed3si9n and removed request for xuwei-k March 7, 2023 00:06
@mkurz mkurz changed the title g8Scaffold does not overwrite files, but now g8ScaffoldForce does :) Add --force flag to g8Scaffold command Mar 7, 2023
eed3si9n
eed3si9n approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit ccd5abe into foundweekends:develop Mar 7, 2023
@mkurz mkurz deleted the g8ScaffoldForce branch March 7, 2023 14:20
@mkurz
Copy link
Contributor Author

mkurz commented Mar 7, 2023

Thanks! Would you mind releasing my recent fixes?

@mkurz
Copy link
Contributor Author

mkurz commented May 1, 2023

Any chance for a new release soon? Thanks!

@eed3si9n eed3si9n mentioned this pull request May 1, 2023
Closed
This was referenced May 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurz @eed3si9n