In Scala 2 keep using scala-parser-combinators 1.x (Scala 3: 2.x) #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
commented
Mar 3, 2023
| scalacheck % Test, | ||
| sbtIo % Test, | ||
| scalamock % Test, | ||
| "org.slf4j" % "slf4j-simple" % "1.7.36" % Test | ||
| ) ++ | ||
| (CrossVersion.partialVersion(scalaVersion.value) match { |
There was a problem hiding this comment.
We don't need to care about Scala 2.11 anymore, was dropped in #428
mkurz
commented
Mar 3, 2023
| def parserCombinator(scalaVersion: String) = "org.scala-lang.modules" %% "scala-parser-combinators" % { | ||
| CrossVersion.partialVersion(scalaVersion) match { | ||
| case Some((2, _)) => "1.1.2" // Do not upgrade beyond 1.x | ||
| case _ => "2.2.0" |
There was a problem hiding this comment.
Scala 2 always keep using 1.x, when cross compiling to Scala 3 in future it can use 2.x.
|
Not sure why tests are not running... |
xuwei-k
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrading again like we did in #725 already. Scala 2.12.17 still uses scala-parser-combinators 1.x, also sbt-native packager and many other sbt-plugins still do. #764 should not have been merged...
Only in Scala 3 we should start using scala-parser-combinators 2.x.