Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade scala-parser-combinators to 1.x because of version conflicts #725

Merged

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Oct 3, 2022

Reproducer:

sbt new playframework/play-scala-seed.g8
cd play-scala-seed/
# Edit project/plugins.sbt, change sbt-giter8-scaffold version to 0.15.0
# Now run sbt:
sbt

You end up with:

[error]         * org.scala-lang.modules:scala-parser-combinators_2.12:2.1.1 (early-semver) is selected over {1.1.2, 1.1.1}
[error]             +- org.foundweekends.giter8:giter8-lib_2.12:0.15.0    (depends on 2.1.1)
[error]             +- com.typesafe.sbt:sbt-native-packager:1.5.2 (scalaVersion=2.12, sbtVersion=1.0) (depends on 1.1.1)
[error]             +- com.typesafe.play:sbt-routes-compiler_2.12:2.8.16  (depends on 1.1.2)

The problem is that most sbt plugins didn't upgrade to scala-parser-combinators v2 yet, so that's why this version conflicts occur.
Even the latest release of Scala 2.12 stays on v1 for now: https://github.com/scala/scala/blob/v2.12.17/versions.properties#L22
(But they did upgrade to scala-xml 2.x in 2.12.17 release however)

That's why I think it makes sense to downgrade in giter8 for now, until there is like a consens in the Scala world when plugins (that run on Scala 2.12) upgrade to v2. (That happened with scala-xml recently, where the scala-compiler and many sbt plugins upgraded scala-xml to v2)

Would it be possible to release 0.15.1 or 0.16 with that pr merged? Thanks!

@mkurz mkurz requested review from eed3si9n and xuwei-k as code owners October 3, 2022 14:54
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense to me.

@mkurz
Copy link
Contributor Author

mkurz commented Oct 3, 2022

PR is green, @eed3si9n would you mind cutting a new release? Thanks!

@eed3si9n eed3si9n merged commit 8b47311 into foundweekends:develop Oct 3, 2022
@mkurz mkurz deleted the downgrade_scala-parser-combinators branch October 3, 2022 15:30
@mkurz
Copy link
Contributor Author

mkurz commented Oct 3, 2022

Sorry for nagging 👀 Has someone time to release a new version? Thank you!

@eed3si9n
Copy link
Member

eed3si9n commented Oct 4, 2022

I released two versions

@mkurz
Copy link
Contributor Author

mkurz commented Oct 4, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants