Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge): show additional details of contract to verify #9403

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(forge): show additional details of contract to verify #9403

merged 1 commit into from
Nov 25, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #4555

Solution

  • display Compiler version, Optimisations and Constructor args (if any) of the contract to be verified

@grandizzy grandizzy marked this pull request as ready for review November 25, 2024 11:12
@yash-atreya yash-atreya merged commit eae5fb4 into foundry-rs:master Nov 25, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-4555 branch November 25, 2024 11:36
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@grandizzy @rplusq
feat(forge): show additional details of contract to verify (foundry-r…
28c516b 
…s#9403)
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@yash-atreya yash-atreya yash-atreya approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge script --verify should output constructor args, compiler version and optimisations
3 participants
@grandizzy @yash-atreya @zerosnacks