Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge script --verify should output constructor args, compiler version and optimisations #4555

Closed
miohtama opened this issue Mar 14, 2023 · 0 comments · Fixed by #9403
Closed

forge script --verify should output constructor args, compiler version and optimisations #4555

miohtama opened this issue Mar 14, 2023 · 0 comments · Fixed by #9403
Assignees
@grandizzy
Labels
C-forge Command: forge Cmd-forge-script Command: forge script first issue A good way to start contributing T-feature Type: feature
Milestone
v1.0.0

Comments

@miohtama
Copy link

miohtama commented Mar 14, 2023 •
edited by zerosnacks
Loading

Component

Forge

Describe the feature you would like

Because EtherScan is a flaky mistress and contract verification fails more often than less, it would be good developer experience to make retrying the contract verification as easy as possible.

A low hanging fruit to optimise the developer experience here is to make sure that all parameters needed to submit the verification are obvious. This can be accomplish by forge script outputting used parameters in the stdout when forge script --verify is run.

Now forge prints

Start verifying contract `...` deployed on polygon

More context needs to be added:

Start verifying contract `...` deployed on polygon
Compiler version: Solidity xxx...
Optimisations: 200
Constructor args: 0x000000....

Additional context

Add pic here where I am pulling out my hair with EtherScan.gif
@miohtama miohtama added the T-feature Type: feature label Mar 14, 2023
@gakonst gakonst added this to Foundry Mar 14, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Mar 14, 2023
@zerosnacks zerosnacks changed the title forge build --verify should output constructor args, compiler version and optimisations forge script --verify should output constructor args, compiler version and optimisations Jul 1, 2024
@zerosnacks zerosnacks added C-forge Command: forge Cmd-forge-script Command: forge script labels Jul 1, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@grandizzy grandizzy added the first issue A good way to start contributing label Nov 5, 2024
@grandizzy grandizzy mentioned this issue Nov 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Nov 25, 2024
@grandizzy grandizzy self-assigned this Nov 25, 2024
@grandizzy grandizzy moved this from Done to Completed in Foundry Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grandizzy grandizzy

Labels
C-forge Command: forge Cmd-forge-script Command: forge script first issue A good way to start contributing T-feature Type: feature
Projects
Foundry
Status: Completed
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

feat(forge): show additional details of contract to verify grandizzy/foundry
3 participants
@miohtama @grandizzy @zerosnacks