fix incorrect info about custom data and fix prototype link #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either the source files that have panini preconfigured need to be updated to add the `data: 'src/data'` path or the documentation should reflect the requirement. Also the prototyping link was dead. I'm not sure if this is the correct new link but I've added it for now.
|
@rafibomb do you think the boilerplate/template should just include the |
|
Good question! Let's see what @kball thinks |
|
@zebapy I think it would make sense to have data in there by default with a sample/empty data file there as an example. |
|
@rafibomb I can add that, sure. That would be done in the template project, right? |
|
Yes! The foundation-emails-template is what creates the project structure! Can you add it there too and the docs here can describe it. |
|
@rafibomb There's a PR open for custom data. I'll update this PR to remove the doc change and leave the link fix. foundation/foundation-emails-template#20 |
|
Thanks @zebapy! Merged in the updated Panini copy. |
|
Ohk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either the source files that have panini preconfigured need to be updated to add the
data: 'src/data'path or the documentation should reflect the requirement.Also the prototyping link was dead. I'm not sure if this is the correct new link but I've added it for now.
Edited Remade PR as requested by @rafibomb in #492