Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom data #20

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Custom data #20

wants to merge 3 commits into from

Conversation

zebapy
Copy link

@zebapy zebapy commented Jul 8, 2016

Adds custom data file by default

Closes foundation/foundation-emails#493 as the documentation update isn't necessary if this is merged

develop was out of date with master so that is part of this as well. If that's not how this should be handled, let me know.

@thomaswelton
Copy link

Thanks for the example

@rafibomb
Copy link
Member

Thanks for the PR! There seems to be some extra files here. Can you rebase or branch of of develop to resubmit for merge?

@zebapy
Copy link
Author

zebapy commented Nov 18, 2016

@rafibomb is that better?

@jimmyko
Copy link

jimmyko commented Mar 23, 2017

I am doing exactly the same thing for my project and planning to make a pull request. But I just gave it up after seeing this.

Just one comment. I think adding .gitkeep file inside data folder is good enough. data.yml is not necessary because the data files should be created by developer.

@DanielRuf
Copy link
Contributor

This should be merged. At the moment the docs do not describe this. The data property is missing by default. cc @maximilianue

@DanielRuf
Copy link
Contributor

I think it is good to have the documentation in the file as it is in the project and always available as a reference. The docs are always changing and not bound to specific releases or may be too new in some cases (think about maintaining an old panini / foundation-emails-template project in the future).

@DanielRuf
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants