Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent empty parent xml overwrites #1308

Merged
merged 8 commits into from
May 10, 2024
Merged

fix: prevent empty parent xml overwrites #1308

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d7b0fd6
test: snapshot for single field retrieve
mshanemc May 9, 2024
8c3ebbb
test: get folder, tmpDir set up
mshanemc May 9, 2024
9283a63
test: getting paths fixed up
mshanemc May 9, 2024
3cd8da5
test: testDir cleanup
mshanemc May 9, 2024
810364d
tests: snapshotTests (broken)
mshanemc May 10, 2024
c238a07
fix: don't blank parent objects that have properties
mshanemc May 10, 2024
bcd18f1
test: bump deps for xNuts
mshanemc May 10, 2024
5c138bc
test: ignore scripts in install
mshanemc May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: snapshotTests (broken)
  • Loading branch information
@mshanemc
mshanemc committed May 10, 2024
commit 810364d7efe35a29ece0d9335bacb5640b05bdbf
1 change: 1 addition & 0 deletions src/convert/transformers/decomposedMetadataTransformer.ts
View file
Original file line number Diff line number Diff line change
@@ -266,6 +266,7 @@ type ComposedMetadataWithChildType = ComposedMetadata & { childType: MetadataTyp
type InfoContainer = {
entryName?: string;
childComponent: MetadataComponent;
/** the parsed xml */
value: JsonMap;
parentComponent: SourceComponent;
mergeWith?: SourceComponent;
63 changes: 63 additions & 0 deletions ...ify-force-app.expected/force-app/main/default/objects/Broker__c/Broker__c.object-meta.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<?xml version="1.0" encoding="UTF-8"?>
<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
<actionOverrides>
<actionName>Accept</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>CancelEdit</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>Clone</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>Delete</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>Edit</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>List</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>New</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>SaveEdit</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>Tab</actionName>
<type>Default</type>
</actionOverrides>
<actionOverrides>
<actionName>View</actionName>
<type>Default</type>
</actionOverrides>
<allowInChatterGroups>false</allowInChatterGroups>
<compactLayoutAssignment>Broker_Compact</compactLayoutAssignment>
<deploymentStatus>Deployed</deploymentStatus>
<enableActivities>false</enableActivities>
<enableBulkApi>true</enableBulkApi>
<enableFeeds>false</enableFeeds>
<enableHistory>false</enableHistory>
<enableReports>true</enableReports>
<enableSearch>true</enableSearch>
<enableSharing>true</enableSharing>
<enableStreamingApi>true</enableStreamingApi>
<label>Broker</label>
<nameField>
<label>Broker Name</label>
<type>Text</type>
</nameField>
<pluralLabel>Brokers</pluralLabel>
<searchLayouts></searchLayouts>
<sharingModel>ReadWrite</sharingModel>
<visibility>Public</visibility>
</CustomObject>
12 changes: 12 additions & 0 deletions ...-app.expected/force-app/main/default/objects/Broker__c/fields/Broker_Id__c.field-meta.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<CustomField xmlns="http://soap.sforce.com/2006/04/metadata">
<fullName>Broker_Id__c</fullName>
<externalId>true</externalId>
<label>Broker Id</label>
<precision>18</precision>
<required>false</required>
<scale>0</scale>
<trackTrending>false</trackTrending>
<type>Number</type>
<unique>false</unique>
</CustomField>
10 changes: 10 additions & 0 deletions ...orce-app.expected/force-app/main/default/objects/Broker__c/fields/Email__c.field-meta.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<CustomField xmlns="http://soap.sforce.com/2006/04/metadata">
<fullName>Email__c</fullName>
<externalId>false</externalId>
<label>Email</label>
<required>false</required>
<trackTrending>false</trackTrending>
<type>Email</type>
<unique>false</unique>
</CustomField>