fix: prevent empty parent xml overwrites #1308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when retrieving a decomposed type (ex a customField) the API returns the parent (customObject) with only the requested field inside it.
Decomposition removes the requested field from the parent, leaving it empty (a CustomObject with no child xml nodes) and then writes that.
What issues does this PR fix or reference?
forcedotcom/cli#2865
@W-15727064@
repro
have a repo with custom objects in it. (dreamhouse works fine)
sf project retrieve start -m CustomField:Foo__c.Bar__c
before: the object-meta.xml would be blank unless you retrieve the CustomObject, too
after: the object-meta.xml keeps its original values
Note: you can still retrieve a field and end up with an empty parent, as long as you didn't have the parent before. To get the parent's contents, include it in your retrieve (ex:
sf project retrieve start -m CustomField:Foo__c.Bar__c -m CustomObject:Foo__c
)