Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tab): auto activate first tab if no active specified #977

Merged
merged 2 commits into from
Sep 1, 2019
Merged

feat(tab): auto activate first tab if no active specified #977

merged 2 commits into from
Sep 1, 2019

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Aug 28, 2019

Description

This PR activate automatically the first tab if no active tab is specified trough the active class.

Testcase

Before: JSFiddle
After: JSFiddle

Closes

#914

@prudho prudho added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Aug 28, 2019
@prudho prudho added this to the 2.7.8 milestone Aug 28, 2019
y0hami
y0hami previously approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lubber-de
lubber-de previously approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami dismissed stale reviews from lubber-de and themself via 27da078 August 28, 2019 14:44
@y0hami y0hami requested review from y0hami and lubber-de August 28, 2019 14:44
lubber-de
lubber-de approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , what @exoego said (use 'some' instead of 'each') is a good idea though

exoego
exoego approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Sep 1, 2019
@y0hami y0hami changed the title [Tab] Auto activate first tab if no active specified feat(tab): auto activate first tab if no active specified Sep 1, 2019
@y0hami y0hami merged commit 3e129a0 into fomantic:develop Sep 1, 2019
@Kingo64 Kingo64 mentioned this pull request Sep 12, 2019
Closed
@prudho prudho mentioned this pull request Sep 19, 2019
Merged
@prudho prudho deleted the enh-914 branch October 10, 2019 06:41
@GammaGames GammaGames mentioned this pull request Nov 19, 2019
Closed
@Kingo64 Kingo64 mentioned this pull request Jan 10, 2020
Closed
@lubber-de lubber-de mentioned this pull request May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

@y0hami y0hami y0hami approved these changes

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.8
Development

Successfully merging this pull request may close these issues.
4 participants
@prudho @exoego @y0hami @lubber-de