[Tab] Make auto activation of tabs optional #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
added
the
state/awaiting-docs
This was referenced May 29, 2020
|
Please review again, i enhanced the usage of the new parameter, so you could also provide a string to switch to a defined tab |
lubber-de
added
state/has-docs
ColinFrick
approved these changes
May 30, 2020
exoego
reviewed
May 30, 2020
exoego
reviewed
May 30, 2020
|
Yes it's in intented to skip the check if it's null/false. |
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The implemented auto activation of tabs when no active tab is found #977 #1025 lead into some situations where a manual set of the active tab does not work anymore and always the last tab was selected.
This especially happens when tabs are initialized separately. Such situations need the old until FUI 2.7.7 which did not check for existing active tabs at all
This PR adds a new option
autoTabActivation(default true to avoid being a breaking change within the 2.8.x branch)When set to false the behavior is the same as until 2.7.7
When set to a string and no active tab exists, it will use that string as the path name for the tab to be activated.
Testcase
The third tab is supposed to be active
Broken
The last initiated tab is selected
https://jsfiddle.net/z632cfq5
Fixed
The previous selected tab stays selected
https://jsfiddle.net/z632cfq5/1/
Closes
#1255
#1188
atk4/ui#1044