Switch to sassc #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `rake spec` pass :)
|
Thanks! I'll take a look at this this weekend. |
|
Hi @shanecav84! Any chance you might take a look at it? |
|
So sorry! Looking into this now. |
n-b
added a commit
to betagouv/conseillers-entreprises
that referenced
this pull request
Jan 20, 2020
Until fomantic/Fomantic-UI-SASS#3 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you are probably aware, ruby sass is deprecated. This switches the
sassandsass-railsdependencies to theirsassccounterparts, and uses theSassCmodule instead ofSass.In theory, it just works. At least my limited testing did not reveal issues 😃 .
ℹ️ I also added an empty
app/assets/config/manifest.jsin the dummy app forrake specto pass; this is required by Sprockets 4.0.