Switch to fomantic-ui (and to sassc) #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty much a noop, as sass-rails is now simply a redirect to sass-rails.
We still rely on sass (ruby sass) instead of sassc through semantic-ui, which is no longer actively maintained. Its community fork is more active, and there’s a gem integration too. Bummer: it still requires ruby sass :(
Until fomantic/Fomantic-UI-SASS#3 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1 switch to the community fork, fomantic-ui-sass
2.2 make a PR to switch fomantic-ui-sass itself to sassc
2.3 update fomantic-ui-sass once this PR is merged
This means we’re now using fomantic-ui 2.8.4 (from semantic-ui 2.4.2), with a handful of features; the switch to sassc itself may increase performance a little bit, but at this point, even switching to libsass sounds dated. Anyway.