Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conversion compiler warnings #844

Merged
merged 4 commits into from
Aug 29, 2018
Merged

Remove conversion compiler warnings #844

merged 4 commits into from
Aug 29, 2018

Commits on Aug 27, 2018

  1. Remove conversion compiler warning

    When compiling with g++8, I get the following two errors:
    include/fmt/format-inl.h:400:29: error: conversion from ‘int’ to ‘char’ may change value [-Werror=conversion]
           buffer[size++] = zero + static_cast<char>(digit);
                            ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
    include/fmt/format-inl.h:416:28: error: conversion from ‘int’ to ‘char’ may change value [-Werror=conversion]
           buffer[size++] = '0' + digit;
                            ~~~~^~~~~~~
    
    With this change, the errors are gone.
    medithe authored Aug 27, 2018
    Configuration menu
    Copy the full SHA
    22cfa65 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Configuration menu
    Copy the full SHA
    009af37 View commit details
    Browse the repository at this point in the history
  2. Update format-inl.h

    medithe authored Aug 28, 2018
    Configuration menu
    Copy the full SHA
    d2741fd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55fd7da View commit details
    Browse the repository at this point in the history