Remove conversion compiler warnings #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with g++8, I get the following two errors:
include/fmt/format-inl.h:400:29: error: conversion from ‘int’ to ‘char’ may change value [-Werror=conversion]
buffer[size++] = zero + static_cast<char>(digit);
~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
include/fmt/format-inl.h:416:28: error: conversion from ‘int’ to ‘char’ may change value [-Werror=conversion]
buffer[size++] = '0' + digit;
~~~~^~~~~~~
With this change, the errors are gone.
medithe
commented
Aug 28, 2018
vitaut
requested changes
Aug 28, 2018
include/fmt/format-inl.h
Outdated
| @@ -374,7 +374,7 @@ FMT_FUNC char *write_exponent(char *buffer, int exp) { | |||
| *buffer++ = '+'; | |||
| } | |||
| if (exp >= 100) { | |||
| *buffer++ = '0' + static_cast<char>(exp / 100); | |||
| *buffer++ = static_cast<char>('0' + static_cast<char>(exp / 100)); | |||
There was a problem hiding this comment.
It's enough to have only one (outer) static_cast.
include/fmt/format-inl.h
Outdated
| @@ -384,7 +384,7 @@ FMT_FUNC char *write_exponent(char *buffer, int exp) { | |||
| *buffer++ = d[0]; | |||
| *buffer++ = d[1]; | |||
| } else { | |||
| *buffer++ = '0' + static_cast<char>(exp); | |||
| *buffer++ = static_cast<char>('0' + static_cast<char>(exp)); | |||
include/fmt/format-inl.h
Outdated
| @@ -421,7 +421,7 @@ FMT_FUNC void grisu2_gen_digits( | |||
| FMT_ASSERT(false, "invalid number of digits"); | |||
| } | |||
| if (digit != 0 || size != 0) | |||
| buffer[size++] = '0' + static_cast<char>(digit); | |||
| buffer[size++] = static_cast<char>('0' + static_cast<char>(digit)); | |||
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with g++8, I get the following two errors:
With this change, the errors are gone.