Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wattributes visibility warning with some GCC versions #1975

Merged
merged 5 commits into from
Nov 5, 2020
Merged

-Wattributes visibility warning with some GCC versions #1975

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
574cd27
temp: fail build on gcc 6
alexezeder Nov 3, 2020
fe11777
actual fix to eliminate warnings
alexezeder Nov 3, 2020
535a4e5
simplify check for FMT_COMPILE_STRING_VISIBILITY_ATTRIBUTE
alexezeder Nov 4, 2020
f480d30
Revert "temp: fail build on gcc 6"
alexezeder Nov 4, 2020
f74736d
FMT_COMPILE_STRING_VISIBILITY_ATTRIBUTE -> FMT_GCC_VISIBILITY_HIDDEN,…
alexezeder Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3198,17 +3198,24 @@ FMT_CONSTEXPR basic_string_view<Char> compile_string_to_view(
return {s.data(), s.size()};
}

#define FMT_STRING_IMPL(s, base) \
[] { \
/* Use a macro-like name to avoid shadowing warnings. */ \
struct FMT_COMPILE_STRING : base { \
using char_type = fmt::remove_cvref_t<decltype(s[0])>; \
FMT_MAYBE_UNUSED FMT_CONSTEXPR \
operator fmt::basic_string_view<char_type>() const { \
return fmt::detail::compile_string_to_view<char_type>(s); \
} \
}; \
return FMT_COMPILE_STRING(); \
#if FMT_GCC_VERSION
# define FMT_COMPILE_STRING_VISIBILITY_ATTRIBUTE \
alexezeder marked this conversation as resolved.
Show resolved Hide resolved
__attribute__((visibility("hidden")))
#else
# define FMT_COMPILE_STRING_VISIBILITY_ATTRIBUTE
#endif

#define FMT_STRING_IMPL(s, base) \
[] { \
/* Use a macro-like name to avoid shadowing warnings. */ \
struct FMT_COMPILE_STRING_VISIBILITY_ATTRIBUTE FMT_COMPILE_STRING : base { \
alexezeder marked this conversation as resolved.
Show resolved Hide resolved
using char_type = fmt::remove_cvref_t<decltype(s[0])>; \
FMT_MAYBE_UNUSED FMT_CONSTEXPR \
operator fmt::basic_string_view<char_type>() const { \
return fmt::detail::compile_string_to_view<char_type>(s); \
} \
}; \
return FMT_COMPILE_STRING(); \
}()

/**
Expand Down