-Wattributes visibility warning with some GCC versions #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexezeder
force-pushed
the
fix/visibility_warning_gcc_arm
branch
from
a1568d4
to
574cd27
Compare
phprus
reviewed
Nov 3, 2020
phprus
reviewed
Nov 3, 2020
vitaut
requested changes
Nov 4, 2020
alexezeder
changed the title
alexezeder
changed the title
vitaut
reviewed
Nov 4, 2020
vitaut
reviewed
Nov 4, 2020
|
LGTM but please rebase since there seem to be some conflicts. |
hmm... @vitaut, are you sure, because I can see "This branch has no conflicts with the base branch" text here, also I'm able to merge in my local repo |
|
Yes, but I guess I can squash the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.
More info about the problem that should be fixed by this PR: #1973
There are a few steps in this PR:
-fvisibility=hiddento the tests, looks like it was not specific to ARM, but x86_64 gcc-6 also produces this warning, so there was no need to create additional CI configuration, but I didn't know that