build: Fix installation paths #1657
Merged
+41
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
vitaut
reviewed
May 1, 2020
It is not generally true that `CMAKE_INSTALL_<dir>` variables are relative paths: https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files
|
Thank you! |
Closed
1 task
justsmth
pushed a commit
to aws/aws-lc
that referenced
this pull request
Oct 15, 2024
### Description of changes: Currently the pkgconfig files are broken when aws-lc is built with Nix. See https://github.com/jtojnar/cmake-snips?tab=readme-ov-file#concatenating-paths-when-building-pkg-config-files, and the PR made to libfmt fmtlib/fmt#1657 ### Call-outs: I'm not sure if bumping the minimum required CMake version is preferred. The alternative would be to add https://github.com/jtojnar/cmake-snips/blob/master/CMakeScripts/JoinPaths.cmake to the `cmake/` directory in the repository. However, most linux distributions have at least CMake 3.20, if not 3.25 so I don't see why this would be a problem. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
skmcgrail
pushed a commit
to skmcgrail/aws-lc
that referenced
this pull request
Feb 5, 2025
### Description of changes: Currently the pkgconfig files are broken when aws-lc is built with Nix. See https://github.com/jtojnar/cmake-snips?tab=readme-ov-file#concatenating-paths-when-building-pkg-config-files, and the PR made to libfmt fmtlib/fmt#1657 ### Call-outs: I'm not sure if bumping the minimum required CMake version is preferred. The alternative would be to add https://github.com/jtojnar/cmake-snips/blob/master/CMakeScripts/JoinPaths.cmake to the `cmake/` directory in the repository. However, most linux distributions have at least CMake 3.20, if not 3.25 so I don't see why this would be a problem. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit f146851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not generally true that
CMAKE_INSTALL_<dir>variables are relative paths:https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files
This lead to
includedir=/nix/store/9axh4pacy7l4s7ii9j0ij54nmdslj7yy-fmt-6.2.0-dev//nix/store/9axh4pacy7l4s7ii9j0ij54nmdslj7yy-fmt-6.2.0-dev/include.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.