-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yuzu: init at 482 #84117
yuzu: init at 482 #84117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and starts on NixOS unstable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the incorrect hash and minor meta details, this package is building and running.
Adressed review comments. I've noticed you're using |
I based my work off the Citra emulator package, which I'm familiar with. Both emulators originated from the same development team so I figured there's probably a lot of similarities between the two and it would be a good place to start. On the nixpkgs manual it states:
So it sounds like you can use either, but |
Ah, i didn't see that wiki page. Switched over to it.
Indeed, though from what I've heard from over at their Discord server they mostly share frontends at this point. |
Still working on figuring out vulkan support, slowed by compile times. Here's the error in the logs: Just tried adding |
I tried that last week as well, the LunarG |
Good news, I have working vulkan. Let me clean this up a bit and I'll send it your way. |
This seems to be working well: https://github.com/JoshuaFern/nur-package-lab/blob/master/pkgs/misc/emulators/yuzu-mainline/default.nix |
Do you have sound by the way? I'm playing Pokemon Mystery Dungeon DX and I'm soundless over here. Not sure if it's a problem with this game, or if the sound isn't working in general. Edit: Adding |
Thanks a lot! I couldn't figure this one out myself.
Whoops, did not notice that one as i muted it beforehand since it'd sound all crackely because of the framerate. I'll add |
25855a2
to
33a3fc4
Compare
Yes, definitely. I just wanted to confirm |
Anyone wanna merge this? |
33a3fc4
to
c36ab0c
Compare
Would love to see this finally get merged :) /marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
@jtojnar anything else before a merge? |
Tried to build it, turns out Nix thinks its unfree. Why is this package marked as unfree? |
I don't have a Switch so I can't verify if the software functions, but it launches. /status needs_merger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging based on:
- code LGTM 👍
- approval by @jtojnar
- extensive testing by my kids 😆
Thanks @IvarWithoutBones and all 🎉 |
I'm really happy we finally managed to get this merged.
@kisik21 Icons are licensed under |
Motivation for this change
This adds the yuzu-mainline package, a Nintendo Switch emulator.
TheEDIT: The issue is fixed, this is no longer required.DENABLE_VULKAN=No
CMake flag is used due to this issue.Libressl is included as its required for this issue.EDIT: The issue is fixed, this is no longer required.Closes #58176
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)