-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): getSSID and getBSSID always returning null #175
Conversation
I do not know iOS much. Requesting @Niek @diegotori, can you review the fix? |
Did some basic google searches, looks like since we are setting These fix adds a callback to @DominikStarke correct me if my understanding is wrong. Resources: This fix LGTM, waiting for others to review. |
@daadu LGTM as well, since it's now handling the iOS result much better. |
Yes. The current implementation is running out of scope. getSSID returns before fetchCurrent's handler is executed. |
I added another commit to apply this fix to getBSSID. |
Thanks @DominikStarke for the fix. This has landed on pub.dev with v0.3.7 |
This patch adresses issues
#161
and
#105
It adds a callback function to getSSID, which will resolve the result.
This is since NEHotspotNetwork.fetchCurrent's completionHandler is escaping. As a result ssid will never be set.