[Fix] Add --[no-]shrink instruction for release builds #11022
Conversation
piedcipher
requested review from
sfshaza2,
parlough,
domesticmouse and
MaryaBelanger
as code owners
piedcipher
changed the title
|
Visit the preview URL for this PR (updated for commit 2557808): https://flutter-docs-prod--pr11022-fix-10032-lovf6unv.web.app |
There was a problem hiding this comment.
Thanks for working to address this older issue!
It seems like instead of having a note, this section needs to be removed or rewritten to not mention --[no-]shrink at all anymore.
@gmackall Is there anything still relevant to developers for shrinking? Is it sufficient to just tell them that Flutter runs shrinking on release builds and link to the Android shrink docs?
Sorry for missing this ping! Yes, that is correct. From what I can tell, the flag has been ignored since So
|
…m code" (#153868) Re-lands #136880, fixes #136879. Additions to/things that are different from the original PR: - Adds an entry to `gradle_errors.dart` that tells people when they run into the R8 bug because of using AGP 7.3.0 (https://issuetracker.google.com/issues/242308990). - Previous PR moved templates off of AGP 7.3.0. - Packages repo has been moved off AGP 7.3.0 (flutter/packages#7432). Also, unrelatedly: - Deletes an entry in `gradle_errors.dart` that informed people to build with `--no-shrink`. This flag [doesn't do anything](flutter/website#11022 (comment)), so it can't be the solution to any error. - Uniquely lowers the priority of the `incompatibleKotlinVersionHandler`. This is necessary because the ordering of the errors doesn't fully determine the priority of which handler we decide to use, but also the order of the log lines. The kotlin error lines often print before the other error lines, so putting it last in the list of handlers isn't sufficient to lower it to be the lowest priority handler.
…m code" (flutter#153868) Re-lands flutter#136880, fixes flutter#136879. Additions to/things that are different from the original PR: - Adds an entry to `gradle_errors.dart` that tells people when they run into the R8 bug because of using AGP 7.3.0 (https://issuetracker.google.com/issues/242308990). - Previous PR moved templates off of AGP 7.3.0. - Packages repo has been moved off AGP 7.3.0 (flutter/packages#7432). Also, unrelatedly: - Deletes an entry in `gradle_errors.dart` that informed people to build with `--no-shrink`. This flag [doesn't do anything](flutter/website#11022 (comment)), so it can't be the solution to any error. - Uniquely lowers the priority of the `incompatibleKotlinVersionHandler`. This is necessary because the ordering of the errors doesn't fully determine the priority of which handler we decide to use, but also the order of the log lines. The kotlin error lines often print before the other error lines, so putting it last in the list of handlers isn't sufficient to lower it to be the lowest priority handler.
Add --[no-]shrink instruction for release builds.
Fixes: #10032
Presubmit checklist