Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'--no-shrink' flag documentation is out of date #10032

Closed
1 task
gmackall opened this issue Jan 11, 2024 · 3 comments · Fixed by #11022
Closed
1 task

'--no-shrink' flag documentation is out of date #10032

gmackall opened this issue Jan 11, 2024 · 3 comments · Fixed by #11022
Assignees
@Martins100-Tmd
Labels
co.volunteer Community wants to work on this dev.deployment Relates to deploying Flutter app section of Flutter.dev e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. target.Android Target apps on the Android Platform

Comments

@gmackall
Copy link
Member

Page URL

https://docs.flutter.dev/deployment/android#shrinking-your-code-with-r8

Page source

No response

Describe the problem

Our documentation doesn't note that the --no-shrink flag has no effect on release builds. Running flutter build apk --help --verbose provides the following

--[no-]shrink                                            This flag has no effect. Code shrinking is always enabled in release builds. To learn more, see:
                                                             https://developer.android.com/studio/build/shrink-code

We should update the page to reflect this.

This was initially reported in flutter/flutter#141164, so I'm making this issue to track it as a website issue instead. Thanks @yanshouwang for the issue report.

Expected fix

No response

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@gmackall gmackall added the from.page-issue Reported in a reader-filed concern label Jan 11, 2024
@gmackall gmackall mentioned this issue Jan 11, 2024
Closed
@huycozy huycozy added st.triage.triage-team Triage team reviewing and categorizing the issue p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs target.Android Target apps on the Android Platform dev.deployment Relates to deploying Flutter app section of Flutter.dev and removed st.triage.triage-team Triage team reviewing and categorizing the issue labels Jan 12, 2024
@atsansone atsansone self-assigned this Jan 16, 2024
@Martins100-Tmd
Copy link

Can I work on this?

@atsansone
Copy link
Contributor

@Martins100-Tmd : Sure! Sorry that we missed your volunteering!

@atsansone atsansone added the co.volunteer Community wants to work on this label Feb 21, 2024
@atsansone
Copy link
Contributor

@Martins100-Tmd : Did you still want to work on this issue?

@piedcipher piedcipher mentioned this issue Aug 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Martins100-Tmd Martins100-Tmd

Labels
co.volunteer Community wants to work on this dev.deployment Relates to deploying Flutter app section of Flutter.dev e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. target.Android Target apps on the Android Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Add --[no-]shrink instruction for release builds piedcipher/website
5 participants
@atsansone @parlough @gmackall @Martins100-Tmd @huycozy