Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breakages introduced by SplashFactory #6952

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix breakages introduced by SplashFactory #6952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1f5fe9
change `Material` elements to `StatelessElement`s
nate-thegrate Jun 19, 2024
b605451
use `Element` type
nate-thegrate Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/animations/test/open_container_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void main() {
));

// Closed container has the expected properties.
final StatefulElement srcMaterialElement = tester.firstElement(
final Element srcMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Closed'),
matching: find.byType(Material),
Expand All @@ -62,7 +62,7 @@ void main() {
await tester.pump();

// On the first frame of the animation everything still looks like before.
final StatefulElement destMaterialElement = tester.firstElement(
final Element destMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Closed'),
matching: find.byType(Material),
Expand Down Expand Up @@ -162,7 +162,7 @@ void main() {
await tester.pump(const Duration(milliseconds: 1));
expect(find.text('Closed'), findsNothing); // No longer in the tree.
expect(find.text('Open'), findsOneWidget);
final StatefulElement finalMaterialElement = tester.firstElement(
final Element finalMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Open'),
matching: find.byType(Material),
Expand Down Expand Up @@ -213,7 +213,7 @@ void main() {
// Open container has the expected properties.
expect(find.text('Closed'), findsNothing);
expect(find.text('Open'), findsOneWidget);
final StatefulElement initialMaterialElement = tester.firstElement(
final Element initialMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Open'),
matching: find.byType(Material),
Expand All @@ -237,7 +237,7 @@ void main() {

expect(find.text('Closed'), findsOneWidget);
expect(find.text('Open'), findsOneWidget);
final StatefulElement materialElement = tester.firstElement(
final Element materialElement = tester.firstElement(
find.ancestor(
of: find.text('Open'),
matching: find.byType(Material),
Expand Down Expand Up @@ -328,7 +328,7 @@ void main() {
await tester.pump(const Duration(milliseconds: 1));
expect(find.text('Open'), findsNothing); // No longer in the tree.
expect(find.text('Closed'), findsOneWidget);
final StatefulElement finalMaterialElement = tester.firstElement(
final Element finalMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Closed'),
matching: find.byType(Material),
Expand Down Expand Up @@ -380,7 +380,7 @@ void main() {
));

// Closed container has the expected properties.
final StatefulElement srcMaterialElement = tester.firstElement(
final Element srcMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Closed'),
matching: find.byType(Material),
Expand All @@ -405,7 +405,7 @@ void main() {
await tester.pump();

// On the first frame of the animation everything still looks like before.
final StatefulElement destMaterialElement = tester.firstElement(
final Element destMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Closed'),
matching: find.byType(Material),
Expand Down Expand Up @@ -509,7 +509,7 @@ void main() {
await tester.pump(const Duration(milliseconds: 1));
expect(find.text('Closed'), findsNothing); // No longer in the tree.
expect(find.text('Open'), findsOneWidget);
final StatefulElement finalMaterialElement = tester.firstElement(
final Element finalMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Open'),
matching: find.byType(Material),
Expand Down Expand Up @@ -558,7 +558,7 @@ void main() {
// Open container has the expected properties.
expect(find.text('Closed'), findsNothing);
expect(find.text('Open'), findsOneWidget);
final StatefulElement initialMaterialElement = tester.firstElement(
final Element initialMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Open'),
matching: find.byType(Material),
Expand All @@ -583,7 +583,7 @@ void main() {

expect(find.text('Closed'), findsOneWidget);
expect(find.text('Open'), findsOneWidget);
final StatefulElement materialElement = tester.firstElement(
final Element materialElement = tester.firstElement(
find.ancestor(
of: find.text('Open'),
matching: find.byType(Material),
Expand Down Expand Up @@ -684,7 +684,7 @@ void main() {
await tester.pump(const Duration(milliseconds: 1));
expect(find.text('Open'), findsNothing); // No longer in the tree.
expect(find.text('Closed'), findsOneWidget);
final StatefulElement finalMaterialElement = tester.firstElement(
final Element finalMaterialElement = tester.firstElement(
find.ancestor(
of: find.text('Closed'),
matching: find.byType(Material),
Expand Down