Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breakages introduced by SplashFactory #6952

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix breakages introduced by SplashFactory #6952

merged 2 commits into from
Aug 13, 2024

Conversation

nate-thegrate
Copy link
Member

@nate-thegrate nate-thegrate mentioned this pull request Jun 20, 2024
Closed
@nate-thegrate nate-thegrate changed the title Fix breakages introduced by InkController Fix breakages introduced by SplashController Jul 11, 2024
@nate-thegrate nate-thegrate changed the title Fix breakages introduced by SplashController Fix breakages introduced by SplashFactory Jul 11, 2024
@nate-thegrate nate-thegrate marked this pull request as ready for review August 8, 2024 20:57
@nate-thegrate
Copy link
Member Author

I realized that instead of changing the type to StatelessElement, we could just use Element, and we'd be able to land it now without breakages!

goderbauer
goderbauer approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2024
@auto-submit auto-submit bot merged commit 66e98d8 into flutter:main Aug 13, 2024
74 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
66e98d8 Fix breakages introduced by SplashFactory (flutter/packages…
ac59a64 
…#6952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
66e98d8 Fix breakages introduced by SplashFactory (flutter/packages…
558fab2 
…#6952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2024
@engine-flutter-autoroll
66e98d8 Fix breakages introduced by SplashFactory (flutter/packages…
a64585f 
…#6952)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 15, 2024
@engine-flutter-autoroll
Roll Packages from e4f2247 to 86d15a6 (7 revisions) (#153499)
ea87865 
flutter/packages@e4f2247...86d15a6

2024-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.2 (flutter/packages#7417)
2024-08-15 tarrinneal@gmail.com [shared_preferences] remove testing section from README (flutter/packages#7410)
2024-08-13 nathan.wilson1232@gmail.com Fix breakages introduced by `SplashFactory` (flutter/packages#6952)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 2afc452 to cc13cd1 (6 revisions) (flutter/packages#7404)
2024-08-13 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert Circle and Marker to Pigeon (flutter/packages#7326)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7379)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/file_selector/file_selector_android/android (flutter/packages#7381)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
@engine-flutter-autoroll @DBowen33
Roll Packages from e4f2247 to 86d15a6 (7 revisions) (flutter#153499)
04eb4ff 
flutter/packages@e4f2247...86d15a6

2024-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.2 (flutter/packages#7417)
2024-08-15 tarrinneal@gmail.com [shared_preferences] remove testing section from README (flutter/packages#7410)
2024-08-13 nathan.wilson1232@gmail.com Fix breakages introduced by `SplashFactory` (flutter/packages#6952)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 2afc452 to cc13cd1 (6 revisions) (flutter/packages#7404)
2024-08-13 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert Circle and Marker to Pigeon (flutter/packages#7326)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7379)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/file_selector/file_selector_android/android (flutter/packages#7381)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from e4f2247 to 86d15a6 (7 revisions) (flutter#153499)
7bd84f7 
flutter/packages@e4f2247...86d15a6

2024-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.2 (flutter/packages#7417)
2024-08-15 tarrinneal@gmail.com [shared_preferences] remove testing section from README (flutter/packages#7410)
2024-08-13 nathan.wilson1232@gmail.com Fix breakages introduced by `SplashFactory` (flutter/packages#6952)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 2afc452 to cc13cd1 (6 revisions) (flutter/packages#7404)
2024-08-13 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert Circle and Marker to Pigeon (flutter/packages#7326)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7379)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/file_selector/file_selector_android/android (flutter/packages#7381)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: animations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nate-thegrate @goderbauer