-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overriding ErrorWidget.builder
#6302
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
## 1.0.26 | ||
* Supports overriding the error widget builder. | ||
|
||
## 1.0.25 | ||
* Adds support for wildget builders. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -244,7 +244,7 @@ void main() { | |
), | ||
); | ||
expect(tester.takeException().toString(), contains('Could not find remote widget named')); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, 'Could not find remote widget named widget in a, possibly because some dependencies were missing: b'); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, contains('Could not find remote widget named widget in a, possibly because some dependencies were missing: b')); | ||
}); | ||
|
||
testWidgets('Missing libraries in specified widget', (WidgetTester tester) async { | ||
|
@@ -258,7 +258,7 @@ void main() { | |
), | ||
); | ||
expect(tester.takeException().toString(), contains('Could not find remote widget named')); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, 'Could not find remote widget named widget in a, possibly because some dependencies were missing: a'); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, contains('Could not find remote widget named widget in a, possibly because some dependencies were missing: a')); | ||
}); | ||
|
||
testWidgets('Missing libraries in import via dependency', (WidgetTester tester) async { | ||
|
@@ -276,7 +276,7 @@ void main() { | |
), | ||
); | ||
expect(tester.takeException().toString(), contains('Could not find remote widget named')); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, 'Could not find remote widget named test in a, possibly because some dependencies were missing: b'); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, contains('Could not find remote widget named test in a, possibly because some dependencies were missing: b')); | ||
}); | ||
|
||
testWidgets('Missing widget', (WidgetTester tester) async { | ||
|
@@ -291,7 +291,7 @@ void main() { | |
), | ||
); | ||
expect(tester.takeException().toString(), contains('Could not find remote widget named')); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, 'Could not find remote widget named widget in a.'); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, contains('Could not find remote widget named widget in a.')); | ||
}); | ||
|
||
testWidgets('Runtime', (WidgetTester tester) async { | ||
|
@@ -1152,7 +1152,29 @@ void main() { | |
|
||
expect(tester.takeException().toString(), contains(expectedErrorMessage)); | ||
expect(find.byType(ErrorWidget), findsOneWidget); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, expectedErrorMessage); | ||
expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, contains(expectedErrorMessage)); | ||
}); | ||
|
||
|
||
testWidgets('Customized error widget', (WidgetTester tester) async { | ||
final ErrorWidgetBuilder oldBuilder = ErrorWidget.builder; | ||
ErrorWidget.builder = (FlutterErrorDetails details) { | ||
return const Text('oopsie!', textDirection: TextDirection.ltr); | ||
}; | ||
final Runtime runtime = Runtime() | ||
..update(const LibraryName(<String>['a']), parseLibraryFile('')); | ||
final DynamicContent data = DynamicContent(); | ||
await tester.pumpWidget( | ||
RemoteWidget( | ||
runtime: runtime, | ||
data: data, | ||
widget: const FullyQualifiedWidgetName(LibraryName(<String>['a']), 'widget'), | ||
), | ||
); | ||
expect(tester.takeException().toString(), contains('Could not find remote widget named')); | ||
expect(find.text('oopsie!'), findsOneWidget); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should probably also check that you can't find an ErrorWidget. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! |
||
expect(find.byType(ErrorWidget), findsNothing); | ||
ErrorWidget.builder = oldBuilder; | ||
}); | ||
|
||
testWidgets('Widget builders - work when scope is not used', (WidgetTester tester) async { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why "contains"? what else does it contain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
_defaultErrorWidgetBuilder
also adds "\nSee also: https://flutter.dev/docs/testing/errors" to the error message.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Looks like that's only included in debug builds. That's probably fine.