Support overriding ErrorWidget.builder
#6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Mar 11, 2024
packages/rfw/coverage/lcov.info
Outdated
| @@ -0,0 +1,3519 @@ | |||
| SF:lib/src/dart/binary.dart | |||
There was a problem hiding this comment.
this file should not be checked in. you can add it to the .gitignore if that helps.
Hixie
reviewed
Mar 12, 2024
| @@ -244,7 +244,7 @@ void main() { | |||
| ), | |||
| ); | |||
| expect(tester.takeException().toString(), contains('Could not find remote widget named')); | |||
| expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, 'Could not find remote widget named widget in a, possibly because some dependencies were missing: b'); | |||
| expect(tester.widget<ErrorWidget>(find.byType(ErrorWidget)).message, contains('Could not find remote widget named widget in a, possibly because some dependencies were missing: b')); | |||
There was a problem hiding this comment.
why "contains"? what else does it contain?
There was a problem hiding this comment.
The _defaultErrorWidgetBuilder also adds "\nSee also: https://flutter.dev/docs/testing/errors" to the error message.
There was a problem hiding this comment.
I see. Looks like that's only included in debug builds. That's probably fine.
Hixie
reviewed
Mar 12, 2024
| ), | ||
| ); | ||
| expect(tester.takeException().toString(), contains('Could not find remote widget named')); | ||
| expect(find.text('oopsie!'), findsOneWidget); |
There was a problem hiding this comment.
should probably also check that you can't find an ErrorWidget.
peixinli
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 14, 2024
flutter/packages@38711ac...b21c542 2024-03-14 pageli328@gmail.com Support overriding `ErrorWidget.builder` (flutter/packages#6302) 2024-03-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 61812ca to 394269f (6 revisions) (flutter/packages#6320) 2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.1 to 4.1.2 (flutter/packages#6309) 2024-03-13 magder@google.com Replace deprecated UIGraphicsBeginImageContextWithOptions with UIGraphicsImageRenderer (flutter/packages#6285) 2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.6 to 3.24.7 (flutter/packages#6310) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
*List which issues are fixed by this PR. You must list at least one issue.* Issue: flutter/flutter#144960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List which issues are fixed by this PR. You must list at least one issue.
Issue: flutter/flutter#144960
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.