Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts "[pointer_interceptor] Add platform interface" #5524

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Reverts "[pointer_interceptor] Add platform interface" #5524

merged 1 commit into from
Nov 30, 2023

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Nov 30, 2023

Reverts #5499
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 1 of #5233

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@auto-submit auto-submit bot requested a review from ditman as a code owner November 30, 2023 14:42
@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Nov 30, 2023
@auto-submit auto-submit bot merged commit bc72d15 into main Nov 30, 2023
3 checks passed
@auto-submit auto-submit bot deleted the revert_98b85dab6f3545dfeee8d004967cbdbf604e8193 branch November 30, 2023 14:43
stuartmorgan added a commit to stuartmorgan/packages that referenced this pull request Nov 30, 2023
@stuartmorgan
Revert "Reverts "[pointer_interceptor] Add platform interface" (flutt…
964565d 
…er#5524)"

This reverts commit bc72d15.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
bc72d15 Reverts "[pointer_interceptor] Add platform interface" (flutt…
5a491d8 
…er/packages#5524)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
Roll Packages from e4aaba8 to bc72d15 (4 revisions) (#139307)
995a020 
flutter/packages@e4aaba8...bc72d15

2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524)
2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519)
2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@auto-submit @HugoOlthof
Reverts "[pointer_interceptor] Add platform interface" (flutter#5524)
00ad845 
Reverts flutter#5499
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of flutter#5233
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll @caseycrogers
Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter#139307)
6ff9f23 
flutter/packages@e4aaba8...bc72d15

2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524)
2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519)
2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@auto-submit @arc-yong
Reverts "[pointer_interceptor] Add platform interface" (flutter#5524)
f811acf 
Reverts flutter#5499
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of flutter#5233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees

@stuartmorgan stuartmorgan

Labels
p: pointer_interceptor revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan @fluttergithubbot