[pointer_interceptor] Add platform interface #5499

LouiseHsu · 2023-11-28T08:26:42Z

Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 1 of #5233

Pre-launch Checklist

flutter-dashboard · 2023-11-28T08:26:45Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

packages/pointer_interceptor/pointer_interceptor_platform_interface/README.md

...eptor/pointer_interceptor_platform_interface/lib/pointer_interceptor_platform_interface.dart

..._interceptor/pointer_interceptor_platform_interface/lib/src/default_pointer_interceptor.dart

...interceptor/pointer_interceptor_platform_interface/lib/src/pointer_interceptor_platform.dart

packages/pointer_interceptor/pointer_interceptor_platform_interface/pubspec.yaml

LouiseHsu · 2023-11-28T20:42:08Z

@stuartmorgan this is ready to review again!

ditman

LGTM! Happy to see the pointer_interceptor grow :P

ditman · 2023-11-29T02:25:44Z

...terceptor/pointer_interceptor_platform_interface/test/pointer_interceptor_platform_test.dart

+    final PointerInterceptorPlatform unimplementedPointerInterceptorPlatform =
+        UnimplementedPointerInterceptorPlatform();
+
+    final Container testChild = Container();
+    expect(
+        () => unimplementedPointerInterceptorPlatform.buildWidget(
+            child: testChild),
+        throwsUnimplementedError);


I'd add another test file: default_pointer_interceptor_test.dart that contains pretty much the same test as this one, but expects that the return from buildWidget is identical to testChild (which is the pass-through feature we really care about!)

auto-submit · 2023-11-29T18:54:20Z

auto label is removed for flutter/packages/5499, due to This PR has not met approval requirements for merging. Changes were requested by {stuartmorgan}, please make the needed changes and resubmit this PR.
You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

stuartmorgan

LGTM with one nit

stuartmorgan · 2023-11-29T19:12:33Z

packages/pointer_interceptor/pointer_interceptor_platform_interface/pubspec.yaml

+
+topics:
+  - widgets
+  - platform views


Nit: We have a policy for our federated plugins of using the plugin name (with _ converted to - to satisfy pub requirements) as one of the topics to allow finding all the related packages. So we should have - pointer-interceptor in the list as well.

auto-submit · 2023-11-29T20:01:35Z

auto label is removed for flutter/packages/5499, due to - The status or check suite Linux_android custom_package_tests master has failed. Please fix the issues identified (or deflake) before re-applying this label.

stuartmorgan · 2023-11-30T14:42:17Z

This fails publishing; I forgot that spaces aren't allowed in topics, and apparently it's a server-side check so our dry-run publish check didn't fail.

This reverts commit 98b85da.

Reverts #5499 Initiated by: stuartmorgan This change reverts the following previous change: Original Description: Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 1 of #5233

stuartmorgan · 2023-11-30T14:51:44Z

I filed flutter/flutter#139305 to catch this earlier next time, and #5525 is open to re-land.

…s#5499)

flutter/packages@e4aaba8...bc72d15 2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524) 2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499) 2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519) 2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ditman · 2023-11-30T20:22:04Z

apparently it's a server-side check so our dry-run publish check didn't fail.

Another +1 for: dart-lang/pub#3537 and similar failures.

Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 1 of flutter#5233

Reverts flutter#5499 Initiated by: stuartmorgan This change reverts the following previous change: Original Description: Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 1 of flutter#5233

hellohuanlin · 2023-12-13T21:38:14Z

packages/pointer_interceptor/pointer_interceptor_platform_interface/AUTHORS

+# Below is a list of people and organizations that have contributed
+# to the project. Names should be added to the list like so:
+#
+#   Name/Organization <email address>


probably wanna put your name there?

This is the format example.

The actual entries are below, and Google-employed contributors are covered by "Google".

flutter/packages@e4aaba8...bc72d15 2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524) 2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499) 2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519) 2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 1 of flutter#5233

Reverts flutter#5499 Initiated by: stuartmorgan This change reverts the following previous change: Original Description: Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 1 of flutter#5233

platform interface

f267ed3

LouiseHsu requested a review from stuartmorgan November 28, 2023 08:26

LouiseHsu requested a review from ditman as a code owner November 28, 2023 08:26

github-actions bot added the p: pointer_interceptor label Nov 28, 2023

stuartmorgan requested changes Nov 28, 2023

View reviewed changes

LouiseHsu added 5 commits November 28, 2023 11:37

pr comments

206058a

update read me links

0fbd967

pubspec + authors file

29dd589

fix unimplemented test

38c41e2

add topics

c8c9051

ditman approved these changes Nov 29, 2023

View reviewed changes

LouiseHsu added 2 commits November 29, 2023 10:28

add test for default behaviour

4f8025e

format

98aad1b

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023

stuartmorgan approved these changes Nov 29, 2023

View reviewed changes

add topic

3054075

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023

auto-submit bot merged commit 98b85da into flutter:main Nov 30, 2023
80 checks passed

stuartmorgan added the revert Label used to revert changes in a closed and merged pull request. label Nov 30, 2023

auto-submit bot mentioned this pull request Nov 30, 2023

Reverts "[pointer_interceptor] Add platform interface" #5524

Merged

11 tasks

auto-submit bot pushed a commit that referenced this pull request Nov 30, 2023

Revert "[pointer_interceptor] Add platform interface (#5499)"

828a3a0

This reverts commit 98b85da.

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Nov 30, 2023

engine-flutter-autoroll mentioned this pull request Nov 30, 2023

Roll Packages from e4aaba833261 to bc72d15c95a5 (4 revisions) flutter/flutter#139307

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 30, 2023

98b85da [pointer_interceptor] Add platform interface (flutter/package…

391622f

…s#5499)

HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023

[pointer_interceptor] Add platform interface (flutter#5499)

fcf4e02

Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 1 of flutter#5233

hellohuanlin reviewed Dec 13, 2023

View reviewed changes

reidbaker mentioned this pull request Jan 12, 2024

Dialog Debug #5881

Closed

reidbaker mentioned this pull request Jan 19, 2024

[in_app_purchase] Add play country code api #5941

Merged

12 tasks

reidbaker mentioned this pull request Feb 19, 2024

[in_app_purchase_android] Add UserChoiceBilling mode. #6162

Merged

16 tasks

arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024

[pointer_interceptor] Add platform interface (flutter#5499)

9c7e349

Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 1 of flutter#5233

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pointer_interceptor] Add platform interface #5499

[pointer_interceptor] Add platform interface #5499

LouiseHsu commented Nov 28, 2023 •

edited

Loading

flutter-dashboard bot commented Nov 28, 2023

LouiseHsu commented Nov 28, 2023

ditman left a comment

ditman Nov 29, 2023 •

edited

Loading

auto-submit bot commented Nov 29, 2023

stuartmorgan left a comment

stuartmorgan Nov 29, 2023

auto-submit bot commented Nov 29, 2023

stuartmorgan commented Nov 30, 2023

stuartmorgan commented Nov 30, 2023

ditman commented Nov 30, 2023 •

edited

Loading

hellohuanlin Dec 13, 2023

stuartmorgan Dec 13, 2023

[pointer_interceptor] Add platform interface #5499

[pointer_interceptor] Add platform interface #5499

Conversation

LouiseHsu commented Nov 28, 2023 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Nov 28, 2023

LouiseHsu commented Nov 28, 2023

ditman left a comment

Choose a reason for hiding this comment

ditman Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

auto-submit bot commented Nov 29, 2023

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan Nov 29, 2023

Choose a reason for hiding this comment

auto-submit bot commented Nov 29, 2023

stuartmorgan commented Nov 30, 2023

stuartmorgan commented Nov 30, 2023

ditman commented Nov 30, 2023 • edited Loading

hellohuanlin Dec 13, 2023

Choose a reason for hiding this comment

stuartmorgan Dec 13, 2023

Choose a reason for hiding this comment

LouiseHsu commented Nov 28, 2023 •

edited

Loading

ditman Nov 29, 2023 •

edited

Loading

ditman commented Nov 30, 2023 •

edited

Loading