feat: endless_runner template

[spydon]

Adds the Endless Runner template to the repository.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read the Flutter Style Guide recently, and have followed its advice.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[domesticmouse]

LGTM once @filiph LGTM's

[domesticmouse]

@filiph I'd suggest landing this PR before #2, just so that the CI has something to, you know, CI.

[filiph]

LGTM with a couple of suggestions.

After discussion with @domesticmouse, I decided to include platform subdirectories (I'm including android/, ios/ and web/). It does have its advantages, plus it looks like the CI is currently not set up to create these subdirectories on its own.

[spydon]

LGTM with a couple of suggestions.

Thanks for the fixes!

It does have its advantages, plus it looks like the CI is currently not set up to create these subdirectories on its own.

What are the advantages of this? From what I have seen previously it usually just becomes more maintenance work to include the platform directories, since we don't do any changes in there and since they change between Flutter versions you want the users to have the latest platform directories created by flutter create, especially cumbersome when it comes to iOS and MacOS.

[filiph]

@domesticmouse I see that the CI is being skipped and I'm not sure what I can do with this. Please advise.

[filiph]

Oh, I just realized that there's no test in the template. Do you think you could add a simple smoke test, @spydon? It can be something similar to what's in basic or card. We want to ensure that the projects not only analyze well, but also run. It only catches the most egregious problems, but even that is something.

[spydon]

Oh, I just realized that there's no test in the template. Do you think you could add a simple smoke test, @spydon? It can be something similar to what's in basic or card. We want to ensure that the projects not only analyze well, but also run. It only catches the most egregious problems, but even that is something.

Ah yes, I had that on my todo-list, but forgot about it!

[domesticmouse]

@filiph Ahh look, we now have CI on this PR, progress!

[domesticmouse]

Added templates/endless_runner to CI config, so this PR becomes actually self testing =)

[filiph]

Hi @spydon,

There are some analyzer problems:

   info • The imported package 'logging' isn't a dependency of the importing package •
          lib/audio/audio_controller.dart:8:8 • depend_on_referenced_packages
warning • Unused import: 'package:flame/events.dart' • lib/flame_game/components/player.dart:3:8 •
       unused_import
   info • The imported package 'logging' isn't a dependency of the importing package •
          lib/settings/settings.dart:6:8 • depend_on_referenced_packages

NVM, that was an easy fix.

[domesticmouse]

Hi @spydon,

There are some analyzer problems:

   info • The imported package 'logging' isn't a dependency of the importing package •
          lib/audio/audio_controller.dart:8:8 • depend_on_referenced_packages
warning • Unused import: 'package:flame/events.dart' • lib/flame_game/components/player.dart:3:8 •
       unused_import
   info • The imported package 'logging' isn't a dependency of the importing package •
          lib/settings/settings.dart:6:8 • depend_on_referenced_packages

NVM, that was an easy fix.

@filiph I'm guessing you are going to add a fix to this PR for the above issues?

[filiph]

@filiph I'm guessing you are going to add a fix to this PR for the above issues?

I thought it would be automatic but it turns out to be a pull request on @spydon's repo. ¯\_(ツ)_/¯
spydon#1

[domesticmouse]

@filiph I'm guessing you are going to add a fix to this PR for the above issues?

I thought it would be automatic but it turns out to be a pull request on @spydon's repo. ¯_(ツ)_/¯ spydon#1

hold my beer...

[filiph]

I know this is not the place to ask, but... how? How did you do this? Are you using the gh CLI tool?

[domesticmouse]

I know this is not the place to ask, but... how? How did you do this? Are you using the gh CLI tool?

I'm using the GitHub Desktop for mac to check out the repos, and my VSCode is logged into GitHub. Between all of the above it just worked ^(TM)

[domesticmouse]

Argh, this one we need to fix:

info - lib/main.dart:55:15 - 'useMaterial3' is deprecated and shouldn't be used. Use a ThemeData constructor (.from, .light, or .dark) instead. These constructors all have a useMaterial3 argument, and they set appropriate default values based on its value. See the useMaterial3 API documentation for full details. This feature was deprecated after v3.13.0-0.2.pre. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use

[spydon]

I know this is not the place to ask, but... how? How did you do this? Are you using the gh CLI tool?

You don't need any special tool for that, as long as the PR owner has "Allow edits and access to secrets by maintainers" the maintainer can just check out the same branch as the PR owner and push directly to that one. It makes it simpler with the gh tool though, since you don't have to fiddle with remotes.

[domesticmouse]

@spydon it looks like your flutterNesTheme is not compliant with Flutter 3.16 beta. Can you go to flutter channel beta and figure out a fix? Alternatively, we can drop useMaterial3: true because I think that becomes default in Flutter 3.16. I think.

[spydon]

@spydon it looks like your flutterNesTheme is not compliant with Flutter 3.16 beta. Can you go to flutter channel beta and figure out a fix? Alternatively, we can drop useMaterial3: true because I think that becomes default in Flutter 3.16. I think.

When is 3.16 to be released? If it is soon I suggest we just drop it.

[domesticmouse]

When is 3.16 to be released? If it is soon I suggest we just drop it.

About the same time as this repo goes live, give or take.

[domesticmouse]

@filiph please feel free to land when you are happy. I'm going to bed soon =)

[spydon]

Oh, I just realized that there's no test in the template. Do you think you could add a simple smoke test, @spydon? It can be something similar to what's in basic or card. We want to ensure that the projects not only analyze well, but also run. It only catches the most egregious problems, but even that is something.

Added two simple smoke tests in e3ab251

[filiph]

@spydon Looks like the flame test times out after 30seconds.

[spydon]

@spydon Looks like the flame test times out after 30seconds.

I wonder what is happening here, it works fine in the IDE (Android Studio), but in the terminal it times out at await game.ready();...

[filiph]

I've never seen this before. If you can't find a solution till tomorrow midday, I suggest you remove that Flame test for now so we can land this.

[spydon]

I've never seen this before. If you can't find a solution till tomorrow midday, I suggest you remove that Flame test for now so we can land this.

There should be a work-around in place now.

[domesticmouse]

Landing on CI green for stable and beta for ubuntu-latest and windows-latest. I don't see anything that should trigger in macos-latest, and those tests always draaaag.