Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code and infrastructure #2

Merged
merged 12 commits into from
Nov 8, 2023
Merged

Initial code and infrastructure #2

merged 12 commits into from
Nov 8, 2023

Conversation

filiph
Copy link
Contributor

@filiph filiph commented Nov 6, 2023

Adding infrastructure from flutter/samples, and the first two templates.

As of creating this pull request, no template or sample is included. I wanted only to include infrastructure first so it's easier to talk about it. The intended file structure looks something like this:

.
├── templates
│   ├── basic
│   ├── card
│   └── sidescroller
└── samples
    ├── ads
    ├── multiplayer
    └── ...

cc @domesticmouse for input

Adding infrastructure from `flutter/samples`, and the first two templates.
.gitattributes Outdated Show resolved Hide resolved
.github/dependabot.yaml Outdated Show resolved Hide resolved
.github/workflows/beta.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@filiph filiph Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I have no idea what these scorecards actually do or what they are. I just blindly copied them over from flutter/samples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paging @godofredoc to explain what dark magic is contained in these scorecards runes

flutter doctor -v

declare -ar PROJECT_NAMES=(
"add_to_app/android_view/flutter_module_using_plugin"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will obviously replace these with the paths in this repo.

flutter doctor -v

declare -ar PROJECT_NAMES=(
"add_to_app/android_view/flutter_module_using_plugin"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as above.

flutter doctor -v

declare -ar PROJECT_NAMES=(
"add_to_app/android_view/flutter_module_using_plugin"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

AUTHORS Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
LICENSE Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we'll need all these licenses (incl. fonts SIL) pretty soon, so I'm keeping the file as is from flutter/samples.

PATENTS Outdated Show resolved Hide resolved
Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the maintenance scripts at top level so they are easy and obvious to both maintain (for me) and delete (for people who fork this code and use it for their own needs)

.gitattributes Outdated Show resolved Hide resolved
.github/dependabot.yaml Outdated Show resolved Hide resolved
- dependency-name: "*"
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
labels:
- "autosubmit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to hassle @godofredoc to make sure this repo has the tooling required to enable auto-landing of dependabot PRs once CI is green.

.github/workflows/beta.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paging @godofredoc to explain what dark magic is contained in these scorecards runes

AUTHORS Outdated Show resolved Hide resolved
PATENTS Outdated Show resolved Hide resolved
Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prune the list of projects to ones that exist in this repo, then land this PR. Thanks!

flutter_ci_script_beta.sh Outdated Show resolved Hide resolved
flutter_ci_script_stable.sh Outdated Show resolved Hide resolved
@domesticmouse domesticmouse mentioned this pull request Nov 7, 2023
8 tasks
@filiph filiph changed the title [WIP] Initial code and infrastructure Initial code and infrastructure Nov 8, 2023
@filiph
Copy link
Contributor Author

filiph commented Nov 8, 2023

Ok, I think this is ready for one final round.

I added the (pre-LGTM'd) code from filiph/game_template into templates/basic and templates/card. I also think the CI now corresponds to what's in the repo.

@domesticmouse
Copy link
Contributor

Ok, I think this is ready for one final round.

I added the (pre-LGTM'd) code from filiph/game_template into templates/basic and templates/card. I also think the CI now corresponds to what's in the repo.

The easy way to find out is to land this PR and then bring #3 up to date and see if it CIs straight. It'll mean updating #3 to include that new project in CI 😎

@filiph
Copy link
Contributor Author

filiph commented Nov 8, 2023

Shall I hit the button on this one, then? I'm happy to add the change to #3. (And sorry, I only saw your comment on #3 now.)

@filiph
Copy link
Contributor Author

filiph commented Nov 8, 2023

Ahhhh, no! I see a problem. One sec.

@domesticmouse
Copy link
Contributor

@filiph do you want to have the honours, or do you want me to land this PR?

@filiph
Copy link
Contributor Author

filiph commented Nov 8, 2023

Ok, now I'm happy. I see that you're okay with this, so I'll do the honors.

@filiph filiph merged commit 44b3db4 into flutter:main Nov 8, 2023
1 check passed
@filiph filiph deleted the infra branch November 8, 2023 10:27
@filiph
Copy link
Contributor Author

filiph commented Nov 8, 2023

Gah, I forgot to cc @johnmccutchan on this PR. John, if you want to review the code again, please feel free. The code is 99.9% the same as the one you reviewed over at https://github.com/filiph/game_template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants