-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code and infrastructure #2
Conversation
Adding infrastructure from `flutter/samples`, and the first two templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I have no idea what these scorecards actually do or what they are. I just blindly copied them over from flutter/samples
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paging @godofredoc to explain what dark magic is contained in these scorecards
runes
.tool/flutter_ci_script_beta.sh
Outdated
flutter doctor -v | ||
|
||
declare -ar PROJECT_NAMES=( | ||
"add_to_app/android_view/flutter_module_using_plugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will obviously replace these with the paths in this repo.
.tool/flutter_ci_script_master.sh
Outdated
flutter doctor -v | ||
|
||
declare -ar PROJECT_NAMES=( | ||
"add_to_app/android_view/flutter_module_using_plugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as above.
.tool/flutter_ci_script_stable.sh
Outdated
flutter doctor -v | ||
|
||
declare -ar PROJECT_NAMES=( | ||
"add_to_app/android_view/flutter_module_using_plugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here.
LICENSE
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we'll need all these licenses (incl. fonts SIL) pretty soon, so I'm keeping the file as is from flutter/samples
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer the maintenance scripts at top level so they are easy and obvious to both maintain (for me) and delete (for people who fork this code and use it for their own needs)
.github/dependabot.yaml
Outdated
- dependency-name: "*" | ||
update-types: ["version-update:semver-minor", "version-update:semver-patch"] | ||
labels: | ||
- "autosubmit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to hassle @godofredoc to make sure this repo has the tooling required to enable auto-landing of dependabot PRs once CI is green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paging @godofredoc to explain what dark magic is contained in these scorecards
runes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prune the list of projects to ones that exist in this repo, then land this PR. Thanks!
Ok, I think this is ready for one final round. I added the (pre-LGTM'd) code from |
The easy way to find out is to land this PR and then bring #3 up to date and see if it CIs straight. It'll mean updating #3 to include that new project in CI 😎 |
Ahhhh, no! I see a problem. One sec. |
@filiph do you want to have the honours, or do you want me to land this PR? |
Ok, now I'm happy. I see that you're okay with this, so I'll do the honors. |
Gah, I forgot to cc @johnmccutchan on this PR. John, if you want to review the code again, please feel free. The code is 99.9% the same as the one you reviewed over at https://github.com/filiph/game_template. |
Adding infrastructure from
flutter/samples
, and the first two templates.As of creating this pull request, no template or sample is included. I wanted only to include infrastructure first so it's easier to talk about it. The intended file structure looks something like this:
cc @domesticmouse for input