Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum height for MaterialBanner #153951

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Add minimum height for MaterialBanner #153951

merged 4 commits into from
Sep 4, 2024
+68 −1

Conversation

mansourzaki
Copy link
Contributor

@mansourzaki mansourzaki commented Aug 22, 2024 •
edited
Loading

This pr allows defining custom minimum height for material banner

fixes this #153666

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 22, 2024
@Piinks Piinks requested a review from QuncCccccc August 28, 2024 18:04
QuncCccccc
QuncCccccc approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution:)

packages/flutter/lib/src/material/banner.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
QuncCccccc
QuncCccccc approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)!

dkwingsmt
dkwingsmt approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions

packages/flutter/lib/src/material/banner.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
piedcipher
piedcipher reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@piedcipher piedcipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some nits

packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/banner_test.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/banner.dart Outdated Show resolved Hide resolved
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2024
@auto-submit auto-submit bot merged commit 4e8df8b into flutter:master Sep 4, 2024
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
4e8df8be3 Add minimum height for MaterialBanner (flutter/flutter#153951)
ee07762
@piedcipher piedcipher mentioned this pull request Sep 4, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8be3 Add minimum height for MaterialBanner (flutter/flutter#153951)
6120db9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8be3 Add minimum height for MaterialBanner (flutter/flutter#153951)
4d37bcd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8be3 Add minimum height for MaterialBanner (flutter/flutter#153951)
7b5231b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8be3 Add minimum height for MaterialBanner (flutter/flutter#153951)
c47dbcb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8be3 Add minimum height for MaterialBanner (flutter/flutter#153951)
a2b8b49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@piedcipher piedcipher piedcipher approved these changes

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mansourzaki @dkwingsmt @piedcipher @QuncCccccc @Piinks