Skip to content

Commit

Permalink
fix nits
Browse files Browse the repository at this point in the history
  • Loading branch information
mansourzaki committed Sep 4, 2024
1 parent 22b0da6 commit 83ab937
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/flutter/lib/src/material/banner.dart
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class MaterialBanner extends StatefulWidget {

/// The optional minimum action bar height.
///
/// Default is 52.0.
/// Default to 52.0.
final double minActionBarHeight;

/// The color of the surface of this [MaterialBanner].
Expand Down
8 changes: 2 additions & 6 deletions packages/flutter/test/material/banner_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ void main() {
});

testWidgets('MinimumActionBarHeight respected', (WidgetTester tester) async {
const double minActionBarHeight = 20;
const double minActionBarHeight = 20.0;
await tester.pumpWidget(
MaterialApp(
home:Scaffold(
Expand All @@ -1165,7 +1165,6 @@ void main() {
actions: <Widget>[
SizedBox.shrink(),
],

),
)
),
Expand All @@ -1177,7 +1176,7 @@ void main() {

testWidgets('MinimumActionBarHeight respects with ScaffoldMessenger', (WidgetTester tester) async {
const Key tapTarget = Key('tap-target');
const double minActionBarHeight = 20;
const double minActionBarHeight = 20.0;
await tester.pumpWidget(MaterialApp(
home: Scaffold(
body: Builder(
Expand Down Expand Up @@ -1208,12 +1207,9 @@ void main() {
await tester.tap(find.byKey(tapTarget));
await tester.pumpAndSettle();


final Size materialBarSize = tester.getSize(find.byType(MaterialBanner));
expect(materialBarSize.height, equals(minActionBarHeight));

});

}

Material _getMaterialFromBanner(WidgetTester tester) {
Expand Down

0 comments on commit 83ab937

Please sign in to comment.