Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ANGLE to flutter/third_party #51270

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Move ANGLE to flutter/third_party #51270

merged 2 commits into from
Mar 8, 2024

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Mar 7, 2024 •
edited
Loading

This moves Flutter out of the buildroot's third_party directory and into //flutter/third_party and updates all BUILD and gni files.

Issue: flutter/flutter#144786
Part of: flutter/flutter#67373

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • The odds of this passing on its first CI run is 0%, because there's no way the licence script isn't going to have a fit over it, at which point I promise on my honour that I will dutifully fix all the things it complains about and re-run, probably more than once.
  • This PR fulfils the minimum Canadian Content regulations mandated by the CRTC.
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Move ANGLE to flutter/third_party
78ee3f1 
This moves Flutter out of the buildroot's third_party directory and into
//flutter/third_party and updates all BUILD and gni files.

Issue: flutter/flutter#144786
Part of: flutter/flutter#67373
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cbracken
Copy link
Member Author

cbracken commented Mar 7, 2024

As noted in the checklist, this is expected to fail on the licence script, and honestly that's a pretty optimistic take.

@Hixie
Copy link
Contributor

Hixie commented Mar 7, 2024

test-exempt: moving dependency

loic-sharma
loic-sharma approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cbracken cbracken merged commit bbb1ed0 into flutter:main Mar 8, 2024
27 checks passed
@cbracken cbracken deleted the angle-to-flutter-third_party branch March 8, 2024 00:23
@cbracken cbracken mentioned this pull request Mar 8, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2024
@engine-flutter-autoroll
bbb1ed00a Move ANGLE to flutter/third_party (flutter/engine#51270)
aa8ebec
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 8, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 80cd7981043f to bbb1ed00af49 (3 revisions) (#…
7018685 
…144813)

flutter/engine@80cd798...bbb1ed0

2024-03-08 chris@bracken.jp Move ANGLE to flutter/third_party (flutter/engine#51270)
2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) (flutter/engine#51268)
2024-03-07 jason-simmons@users.noreply.github.com [Impeller] Fix a buffer overrun in ImpellerC reflector resource offsets (flutter/engine#51108)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@matanlurey matanlurey matanlurey approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees
No one assigned
Labels
affects: desktop e: impeller platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbracken @Hixie @matanlurey @loic-sharma