[Impeller] Fix a buffer overrun in ImpellerC reflector resource offsets #51108
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Testing: this issue can be reproduced by running the (The Impeller tests are not yet running with ASAN on CI) |
| std::optional<size_t> Reflector::GetOffset( | ||
| spirv_cross::ID id, | ||
| const std::vector<size_t>& offsets) const { | ||
| uint32_t location = |
There was a problem hiding this comment.
I didn't know there was just a tool at the time impellerc was written, but there is spriv-val that we can run over the intermediate Stage 1 SPIRV to avoid getting into this situation. But being defensive here make sense to me.
|
test-exempt: Will be tested by ASAN on CI, this gets us closer to being able to enable. |
jason-simmons
added
the
autosubmit
…144813) flutter/engine@80cd798...bbb1ed0 2024-03-08 chris@bracken.jp Move ANGLE to flutter/third_party (flutter/engine#51270) 2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) (flutter/engine#51268) 2024-03-07 jason-simmons@users.noreply.github.com [Impeller] Fix a buffer overrun in ImpellerC reflector resource offsets (flutter/engine#51108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This issue can be reproduced by running the CompilerTest.MustFailDueToMultipleLocationPerStructMember test with ASAN
(The Impeller tests are not yet running with ASAN on CI)