Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new lint from android 14 upgrade, and remove it from the baseline #47817

Merged
merged 15 commits into from
Nov 29, 2023
Merged

Fix new lint from android 14 upgrade, and remove it from the baseline #47817

merged 15 commits into from
Nov 29, 2023

Commits on Nov 8, 2023

  1. fix lint regarding unclosed file descriptor

    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    949afed View commit details
    Browse the repository at this point in the history

  2. format

    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    01b30bf View commit details
    Browse the repository at this point in the history

  3. add missing import

    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c14d853 View commit details
    Browse the repository at this point in the history

  4. still return charsequence if we fail to close fd

    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5c838eb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix_api34_lint

    @gmackall
    gmackall authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c511083 View commit details
    Browse the repository at this point in the history

  6. add a test that we still succeed when the file descriptor fails to close

    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c08f1d3 View commit details
    Browse the repository at this point in the history

  7. format

    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2d00337 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'refs/remotes/origin/fix_api34_lint' int… 

    …o fix_api34_lint
    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    03005ca View commit details
    Browse the repository at this point in the history

  9. fix test?

    Gray Mackall committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    bb17dae View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. wip

    Gray Mackall committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    74b140f View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'flutter:main' into fix_api34_lint

    @gmackall
    gmackall authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f37ab97 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/origin/fix_api34_lint' int… 

    …o fix_api34_lint
    Gray Mackall committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f24c791 View commit details
    Browse the repository at this point in the history

  3. actually make the test work for real this time

    Gray Mackall committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3ad12e9 View commit details
    Browse the repository at this point in the history

  4. format

    Gray Mackall committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e80a7f2 View commit details
    Browse the repository at this point in the history

  5. remove the lint from the baseline, as it is fixed

    Gray Mackall committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3580c7b View commit details
    Browse the repository at this point in the history