Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new lint from android 14 upgrade, and remove it from the baseline #47817

Merged
merged 15 commits into from
Nov 29, 2023

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Nov 8, 2023

See #47609 (comment) for context.

It isn't clear to me what the file descriptor here is actually doing, so I'm not actually too sure about this fix. Can it just be deleted?

Update: it seems to me that the motivation here is that ClipData.Item.coerceToText consumes a SecurityException here, with just a log line that isn't particularly descriptive. And basically we want to run into that same exception so we can provide a more helpful log line, so we do the same thing that the underlying coerceToText method does?

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

reidbaker
reidbaker previously approved these changes Nov 8, 2023
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve % return value change.

@gmackall gmackall marked this pull request as ready for review November 8, 2023 20:57
@flutter-dashboard

This comment was marked as outdated.

@reidbaker
Copy link
Contributor

Task :compileDebugUnitTestJavaWithJavac
/b/s/w/ir/cache/builder/src/flutter/shell/platform/android/test/io/flutter/plugin/platform/PlatformPluginTest.java:132: error: 'void' type not allowed here
when(fakeAssetFileDescriptor.close()).thenThrow(IOException.class);
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

Task :compileDebugUnitTestJavaWithJavac FAILED

@chinmaygarde
Copy link
Member

Are we making progress on this?

@gmackall gmackall marked this pull request as draft November 16, 2023 23:02
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@reidbaker
Copy link
Contributor

@chinmaygarde is this blocking your team? I believe gray update the baseline lint so we think this is non blocking.

@gmackall gmackall changed the title Fix new lint from android 14 upgrade Fix new lint from android 14 upgrade, and remove it from the baseline Nov 28, 2023
@gmackall
Copy link
Member Author

@reidbaker Added a test, and also included the deletion of the baseline item in this PR, so re-requesting review

@gmackall gmackall marked this pull request as ready for review November 29, 2023 00:39
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023
@auto-submit auto-submit bot merged commit 0a005c4 into flutter:main Nov 29, 2023
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 29, 2023
…139242)

flutter/engine@60b9639...222beb2

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from b9e2514a6fb6 to 8931060e9ab5 (1 revision) (flutter/engine#48498)
2023-11-29 34871572+gmackall@users.noreply.github.com Fix new lint from android 14 upgrade, and remove it from the baseline (flutter/engine#47817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gmackall gmackall deleted the fix_api34_lint branch November 29, 2023 19:25
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
…lutter#139242)

flutter/engine@60b9639...222beb2

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from b9e2514a6fb6 to 8931060e9ab5 (1 revision) (flutter/engine#48498)
2023-11-29 34871572+gmackall@users.noreply.github.com Fix new lint from android 14 upgrade, and remove it from the baseline (flutter/engine#47817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants