Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: Remove a11y workaround that disables the a11y when app is resigned. #34086

Merged
merged 2 commits into from
Jun 15, 2022
Merged

iOS: Remove a11y workaround that disables the a11y when app is resigned. #34086

merged 2 commits into from
Jun 15, 2022

Conversation

cyanglaz
Copy link
Contributor

This PR removes the a11y workaround in #29566 and the workaround on top of it to fix the XCUITests alert popups in #32820

The root cause of the issue flutter/flutter#93030 is we are unnecessarily asking accessibility notification to focus on an already focused element. With the root cause fixed in #33972, we can remove the workarounds.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from dnfield June 15, 2022 19:41
@cyanglaz cyanglaz marked this pull request as ready for review June 15, 2022 19:41
@cyanglaz cyanglaz changed the title Remove a11y workaround from https://github.com/flutter/engine/pull/29566 iOS: Remove a11y workaround that disables the a11y when app is resigned. Jun 15, 2022
dnfield
dnfield approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cyanglaz cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 15, 2022
@jmagman jmagman added autosubmit Merge PR when tree becomes green via auto submit App and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Jun 15, 2022
@auto-submit auto-submit bot merged commit fff144c into flutter:main Jun 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
61f1f84 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
b07edce 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
a13aff9 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
8b6cd60 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
a3faeec 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
f2b3022 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
85a9122 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
f2e55bc 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
13f9bd4 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
308a780 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
7ee1dcd 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
43856bc 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
e563b4a 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
07a17b9 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
3d506fe 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
5ece2d2 
…s resigned. (flutter/engine#34086)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
fff144c iOS: Remove a11y workaround that disables the a11y when app i…
67d262a 
…s resigned. (flutter/engine#34086)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@houhuayong
iOS: Remove a11y workaround that disables the a11y when app is resign…
94ae719 
…ed. (flutter#34086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyanglaz @dnfield @jmagman