Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS Accessibility: during layout change, only specify the focus object when it is changed. #33972

Merged
merged 1 commit into from
Jun 15, 2022
Merged

iOS Accessibility: during layout change, only specify the focus object when it is changed. #33972

merged 1 commit into from
Jun 15, 2022

Conversation

cyanglaz
Copy link
Contributor

We currently always specifies a new item to focus when layout changed. It adds a redundant focus request and sometimes mess up the focus if the accessibility focus is changed right before the layout change notification is handled.
See details in: flutter/flutter#104176 (comment)

Fixes: flutter/flutter#104176

I manually tested, this fix doesn't regress flutter/flutter#80991

This PR also will fix flutter/flutter#93030 and we can remove the workaround we had for 93030

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz changed the title iOS Accessibility: , during layout change, only specify the focus object when it is changed. iOS Accessibility: during layout change, only specify the focus object when it is changed. Jun 10, 2022
@cyanglaz
Copy link
Contributor Author

cc @chunhtai so you are aware of this change when you are back from your OOO :)

@cyanglaz cyanglaz marked this pull request as ready for review June 10, 2022 21:18
hellohuanlin
hellohuanlin reviewed Jun 10, 2022
View reviewed changes
shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm Outdated
ios_delegate_->PostAccessibilityNotification(
UIAccessibilityLayoutChangedNotification,
FindNextFocusableIfNecessary().nativeAccessibility);
(routeChanged || next != lastFocused) ? next : NULL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be next.nativeAccessibility instead of next?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, ptal

@cyanglaz cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 15, 2022
@fluttergithubbot fluttergithubbot merged commit 922d3e0 into flutter:main Jun 15, 2022
@cyanglaz cyanglaz deleted the a11y_doubletap branch June 15, 2022 17:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
e070507 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
ba15f26 
…us object when it is changed. (flutter/engine#33972)
@cyanglaz cyanglaz mentioned this pull request Jun 15, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
b5d2391 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
5053bc7 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
69a6603 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
c4608fa 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
e5d0cd8 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
f557aaf 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
5dac0c5 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
5df537e 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
340b517 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
fff2db5 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
184e0f1 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
9ccb4f1 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
690e1cc 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
8cc2bfd 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
69efe9c 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
09fc20d 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
14197da 
…us object when it is changed. (flutter/engine#33972)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
922d3e0 iOS Accessibility: during layout change, only specify the foc…
b0ff6a2 
…us object when it is changed. (flutter/engine#33972)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@houhuayong
iOS Accessibility: during layout change, only specify the focus objec…
3e0338f 
…t when it is changed. (flutter#33972)
This was referenced Jul 29, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@jmagman jmagman Awaiting requested review from jmagman

Assignees
No one assigned
Labels
platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@cyanglaz @hellohuanlin @fluttergithubbot