Removing bindings to avoid memory leaks

[jlcarvalho]

In your Directive keep practice for unbinding the jQuery Event. $destory Method which can be used to clean up DOM bindings before an element is removed from the DOM.

[AidasK]

Nice, thanks

[AidasK]

Hi, I haven't time to write this earlier, but I think I submitted this request too early.
You don't need to unbind events on destroy, because destroy event is called once DOM element is destroyed.
I have also check angularjs directives and they also follows same approach (don't unbind events):
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngEventDirs.js#L61

[jlcarvalho]

Yes, but when i remove one element the events are not removed. Right?
In modern js engines it's not a problem, and i agree with you. But in the others?

Check this links:
angular/angular.js#4864
angular/angular.js#5270
angular/angular.js#5281

[AidasK]

Yea, but as I can see, they have decided to do nothing about it, right?
angular/angular.js#5281 (comment)
So I don't think we should solve problems which are left in the angularjs core. Libraries should follow same style.

[jlcarvalho]

Ok, you're right. We must follow the same style.

By the way, sorry for my english.