Addresses #1454 using pyside6 #1455
Conversation
|
Will need to change the feedstock to add the pyside6 dependency too. May want to expose volpy_gui as a package binary? |
| @@ -27,6 +27,7 @@ dependencies: | |||
| - psutil | |||
| - pynwb | |||
| - pyqtgraph | |||
| - pyside6 | |||
There was a problem hiding this comment.
I wonder if including this in the deps could create issues with opencv, last time I remember it wants to have its own qt installed. That's why I always use opencv-python-headless but I'm not sure if opencv windowed stuff still works but just using the existing qt then.
There was a problem hiding this comment.
Looks like it pulls in qt6-main, so it's at least a closer version; more likely than sticking with qt5-based distros but something to watch out for.
Unfortunately, right now I think some of the code uses opencv's ability to launch a qt-based GUI, I think. I'd need to check to find out where but I'm pretty sure we do it.
|
After a lot of testing, I don't think the PyQt6 and PySide6 coexisting is something we're going to regularly see users face (nothing pulls this in automatically), and this fixes a real issue (pyqt which is QT5 no longer being well supported by other packages we use). I think this approach is the right way forward. |
Upstream changes in pyqtgraph late last year broke the volpy gui because mixing pyqtgraph and PyQt5 became impossible (pyqtgraph routed itself through pyside6 if it's present, causing the app to mix PyQt5 and QT6 objects).
This diff commits volpy to using QT6 through the pyside6 library, avoiding possibilities of mixing them.