Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes and fixes for showing reports against nightly releases and OEM sysexts #149

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Changes and fixes for showing reports against nightly releases and OEM sysexts #149

merged 6 commits into from
Sep 26, 2023

Commits on Sep 22, 2023

  1. show-changes: Allow running the script from different place 

    The show-changes script required to be run from the parent directory
of the scripts/coreos-overlay/portage-stable repositories. The
requirement may be inconvenient in some situations (like the repo
having a different name, or being forced to change the directory
before invoking the script). Allow pointing the show-changes script to
the locations of scripts, coreos-overlay and portage-stable
repositories. If the locations are not overridden, then the script has
the old expectations.
    @krnowak
    krnowak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e824712 View commit details
    Browse the repository at this point in the history

  2. show-changes: Fetch changes from repos once 

    Without the change, the script could be fetching changes twelve times
(once for scripts, once for coreos-overlay and once for
portage-stable, all repeated four times for four change categories).

Just fetch the changes once for each repo if the repo directory
exists. This makes the script much faster.
    @krnowak
    krnowak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    90f2a9e View commit details
    Browse the repository at this point in the history

  3. show-changes: Fix some shellcheck warnings

    @krnowak
    krnowak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    68c3bbc View commit details
    Browse the repository at this point in the history

  4. package-diff: Generalize contents file processing 

    Instead of adding another special case for contents file (as it would
be the case by adding support for OEM sysext image content files) just
expect all files ending with _contents.txt (or contents_wtd.txt) to be
of specific format.
    @krnowak
    krnowak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    6a9f642 View commit details
    Browse the repository at this point in the history

  5. size-change-report: Add support for OEM sysext image content files

    @krnowak
    krnowak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    11f07d3 View commit details
    Browse the repository at this point in the history

  6. size-change-report: Handle the case of unchanged file listings 

    We generate some intermediate files using `git diff` with an option to
generate a large number of context lines in order to print all the
unchanged lines. But if both files are the same, git diff prints no
output at all. In such case, we need to copy one of the files and
prepend a space to it to have a "diff" file with unchanged lines only.

This fixes some ominous warnings about expecting a bad report.
    @krnowak
    krnowak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    b5a7a37 View commit details
    Browse the repository at this point in the history