Changes and fixes for showing reports against nightly releases and OEM sysexts #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The show-changes script required to be run from the parent directory of the scripts/coreos-overlay/portage-stable repositories. The requirement may be inconvenient in some situations (like the repo having a different name, or being forced to change the directory before invoking the script). Allow pointing the show-changes script to the locations of scripts, coreos-overlay and portage-stable repositories. If the locations are not overridden, then the script has the old expectations.
Without the change, the script could be fetching changes twelve times (once for scripts, once for coreos-overlay and once for portage-stable, all repeated four times for four change categories). Just fetch the changes once for each repo if the repo directory exists. This makes the script much faster.
Instead of adding another special case for contents file (as it would be the case by adding support for OEM sysext image content files) just expect all files ending with _contents.txt (or contents_wtd.txt) to be of specific format.
We generate some intermediate files using `git diff` with an option to generate a large number of context lines in order to print all the unchanged lines. But if both files are the same, git diff prints no output at all. In such case, we need to copy one of the files and prepend a space to it to have a "diff" file with unchanged lines only. This fixes some ominous warnings about expecting a bad report.
pothos
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see each of the commit for the changes made and some reasoning.