Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the label to the new 'follow new discussions' preference #75

Closed
wants to merge 1 commit into from
Closed

added the label to the new 'follow new discussions' preference #75

wants to merge 1 commit into from

Conversation

oscarotero
Copy link

@dcsjapan
Copy link
Contributor

dcsjapan commented Jun 4, 2016

@tobscure This looks fine in that the key name matches forum_follow_after_reply_label from #57 ...

... But I'm not sure what the forum_ signifies in either case. Could these two keys do without it?

@tobyzerner
Copy link
Contributor

tobyzerner commented Jun 4, 2016

@dcsjapan Right, the forum_ prefix is unnecessary in both cases.

@dcsjapan
Copy link
Contributor

dcsjapan commented Jun 4, 2016

I'll send a PR to remove both once you've merged this. 😄

@tobyzerner
Copy link
Contributor

Thanks! This one isn't actually going to get merged for now due to issues in its counterpart, flarum/subscriptions#9 (with additional discussion in flarum/framework#768). But a PR for the other one would be greatly appreciated :)

@franzliedke
Copy link
Contributor

Closing, see flarum/framework#768 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants